Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: remoting/test/counter_stubs.h

Issue 1923573006: Implement a dummy host to do capturing and analysis only. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build break on Windows Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
joedow 2016/05/04 16:40:44 Please add macro guard.
Hzj_jie 2016/05/04 19:18:04 Done.
5 #include <memory>
6 #include <ostream>
7
8 #include "remoting/protocol/audio_stub.h"
9 #include "remoting/protocol/client_stub.h"
10 #include "remoting/protocol/fake_connection_to_client.h"
11 #include "remoting/protocol/host_stub.h"
12 #include "remoting/protocol/video_stub.h"
13
14 namespace remoting {
15 namespace test {
16
17 class CounterStubs {
joedow 2016/05/04 16:40:44 Can you make this name more descriptive? It seems
Hzj_jie 2016/05/04 19:18:04 Done.
18 public:
19 CounterStubs(protocol::FakeConnectionToClient* connection = nullptr);
joedow 2016/05/04 16:40:44 single param c'tors should be defined as 'explicit
Hzj_jie 2016/05/04 19:18:04 Done.
20 virtual ~CounterStubs();
joedow 2016/05/04 16:40:44 newline between c'tor/d'tor and getter methods
Hzj_jie 2016/05/04 19:18:04 Done.
21 protocol::ClientStub& client_stub();
22 protocol::HostStub& host_stub();
23 protocol::AudioStub& audio_stub();
24 protocol::VideoStub& video_stub();
25 friend std::ostream& operator<<(std::ostream& os, const CounterStubs& stubs);
26
27 private:
28 class CounterClientStub;
29 class CounterHostStub;
30 class CounterAudioStub;
31 class CounterVideoStub;
joedow 2016/05/04 16:40:44 newline between class forward decls and members.
Hzj_jie 2016/05/04 19:18:04 Done.
32 std::unique_ptr<CounterClientStub> client_stub_;
33 std::unique_ptr<CounterHostStub> host_stub_;
34 std::unique_ptr<CounterAudioStub> audio_stub_;
35 std::unique_ptr<CounterVideoStub> video_stub_;
joedow 2016/05/04 16:40:45 DISALLOW_COPY_AND_ASSIGN(...)?
Hzj_jie 2016/05/04 19:18:04 Done.
36 };
37
38 } // namespace test
39 } // namespace remoting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698