Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 1923563002: Abandon Prerender upon finalizing PrerenderHandle. (Closed)

Created:
4 years, 7 months ago by pasko
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Abandon Prerender upon finalizing PrerenderHandle. Forcefully sever the connection to the embedder upon the PrerenderHandle becoming unreachable and unused. Otherwise we risk Prerender leaks and renderer shutdown crashes when the embedder tries to access Blink after it has already been shut down. R=haraken BUG=602227 Review URL: https://codereview.chromium.org/1872383002 Cr-Commit-Position: refs/heads/master@{#386401} (cherry picked from commit 4224af9fbca8e40376cd4bd591fde530fb394183) Committed: https://chromium.googlesource.com/chromium/src/+/b204d3fcfd7f0d514ad784d18d53769495ab2262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/loader/PrerenderHandle.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
pasko
Committed patchset #1 (id:1) manually as b204d3fcfd7f0d514ad784d18d53769495ab2262.
4 years, 7 months ago (2016-04-26 17:12:55 UTC) #2
haraken
4 years, 7 months ago (2016-04-26 17:28:42 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698