Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1872383002: Abandon Prerender upon finalizing PrerenderHandle. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
haraken, tkent
CC:
chromium-reviews, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, Yoav Weiss, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, kinuko+watch, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Abandon Prerender upon finalizing PrerenderHandle. Forcefully sever the connection to the embedder upon the PrerenderHandle becoming unreachable and unused. Otherwise we risk Prerender leaks and renderer shutdown crashes when the embedder tries to access Blink after it has already been shut down. R=haraken BUG=602227 Committed: https://crrev.com/4224af9fbca8e40376cd4bd591fde530fb394183 Cr-Commit-Position: refs/heads/master@{#386401}

Patch Set 1 #

Patch Set 2 : adjust abandon() call site #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/loader/PrerenderHandle.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-11 14:55:51 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-04-11 15:05:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872383002/20001
4 years, 8 months ago (2016-04-11 15:32:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 16:23:55 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 16:24:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4224af9fbca8e40376cd4bd591fde530fb394183
Cr-Commit-Position: refs/heads/master@{#386401}

Powered by Google App Engine
This is Rietveld 408576698