net/cert/internal/verify_certificate_chain_pkits_unittest.cc - Issue 1923433002: Certificate path builder for new certificate verification library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/verify_certificate_chain_pkits_unittest.cc

Issue 1923433002: Certificate path builder for new certificate verification library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip: Make CertPathIter build the full path including the trust anchor Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/cert/internal/path_builder.h ('K') | « net/cert/internal/verify_certificate_chain.cc ('k') | net/cert/internal/verify_certificate_chain_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/internal/verify_certificate_chain_pkits_unittest.cc

diff --git a/net/cert/internal/verify_certificate_chain_pkits_unittest.cc b/net/cert/internal/verify_certificate_chain_pkits_unittest.cc

index 606563708ae98da1df7bc8e0412616eb28a0d9df..0c1a25fddedf070198c8d57f6d18d06573aac9ad 100644

--- a/net/cert/internal/verify_certificate_chain_pkits_unittest.cc

+++ b/net/cert/internal/verify_certificate_chain_pkits_unittest.cc

@@ -53,7 +53,11 @@ class VerifyCertificateChainPkitsTestDelegate {

}

// First entry in the PKITS chain is the trust anchor.

TrustStore trust_store;

- EXPECT_TRUE(trust_store.AddTrustedCertificate(cert_ders[0]));

+ scoped_refptr<CertThing> anchor(

+ CertThing::CreateFromCertificateCopy(cert_ders[0]));

+ EXPECT_TRUE(anchor);

+ if (anchor)

+ trust_store.AddTrustedCertificate(std::move(anchor));

// PKITS lists chains from trust anchor to target, VerifyCertificateChain

// takes them starting with the target and not including the trust anchor.

« net/cert/internal/path_builder.h ('K') | « net/cert/internal/verify_certificate_chain.cc ('k') | net/cert/internal/verify_certificate_chain_unittest.cc » ('j') | no next file with comments »