net/cert/internal/cert_issuer_source_static_unittest.cc - Issue 1923433002: Certificate path builder for new certificate verification library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/cert_issuer_source_static_unittest.cc

Issue 1923433002: Certificate path builder for new certificate verification library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changes for comment #16 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/cert/internal/cert_issuer_source.h ('K') | « net/cert/internal/cert_issuer_source_static.cc ('k') | net/cert/internal/parsed_certificate.h » ('j') | net/cert/internal/path_builder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/internal/cert_issuer_source_static_unittest.cc

diff --git a/net/cert/internal/cert_issuer_source_static_unittest.cc b/net/cert/internal/cert_issuer_source_static_unittest.cc

index 148f3620dd03113015fc1fd70b8fe01ee9f07b4f..d59744c61abf2c2cba2791752cda344c8fdbd665 100644

--- a/net/cert/internal/cert_issuer_source_static_unittest.cc

+++ b/net/cert/internal/cert_issuer_source_static_unittest.cc

@@ -78,7 +78,7 @@ TEST_F(CertIssuerSourceStaticTest, NoMatch) {

CertIssuerSourceStatic source;

source.AddCert(root_);

- std::vector<scoped_refptr<ParsedCertificate>> issuers;

+ ParsedCertificateList issuers;

source.SyncGetIssuersOf(c1_.get(), &issuers);

ASSERT_EQ(0U, issuers.size());

}

@@ -87,7 +87,7 @@ TEST_F(CertIssuerSourceStaticTest, OneMatch) {

CertIssuerSourceStatic source;

AddAllCerts(&source);

- std::vector<scoped_refptr<ParsedCertificate>> issuers;

+ ParsedCertificateList issuers;

source.SyncGetIssuersOf(i1_1_.get(), &issuers);

ASSERT_EQ(1U, issuers.size());

EXPECT_TRUE(issuers[0] == root_);

@@ -102,7 +102,7 @@ TEST_F(CertIssuerSourceStaticTest, MultipleMatches) {

CertIssuerSourceStatic source;

AddAllCerts(&source);

- std::vector<scoped_refptr<ParsedCertificate>> issuers;

+ ParsedCertificateList issuers;

source.SyncGetIssuersOf(c1_.get(), &issuers);

ASSERT_EQ(2U, issuers.size());

@@ -120,7 +120,7 @@ TEST_F(CertIssuerSourceStaticTest, SelfIssued) {

CertIssuerSourceStatic source;

AddAllCerts(&source);

- std::vector<scoped_refptr<ParsedCertificate>> issuers;

+ ParsedCertificateList issuers;

source.SyncGetIssuersOf(root_.get(), &issuers);

ASSERT_EQ(1U, issuers.size());

« net/cert/internal/cert_issuer_source.h ('K') | « net/cert/internal/cert_issuer_source_static.cc ('k') | net/cert/internal/parsed_certificate.h » ('j') | net/cert/internal/path_builder.h » ('J')