net/cert/internal/cert_issuer_source_static.cc - Issue 1923433002: Certificate path builder for new certificate verification library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/cert_issuer_source_static.cc

Issue 1923433002: Certificate path builder for new certificate verification library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changes for comment #16 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/cert/internal/cert_issuer_source.h ('K') | « net/cert/internal/cert_issuer_source_static.h ('k') | net/cert/internal/cert_issuer_source_static_unittest.cc » ('j') | net/cert/internal/path_builder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/internal/cert_issuer_source_static.cc

diff --git a/net/cert/internal/cert_issuer_source_static.cc b/net/cert/internal/cert_issuer_source_static.cc

index c7685f436a1bbf45b703e26b08614535eba21c5f..52758e6e4f9657c1ecd517589157e84c1ddf7535 100644

--- a/net/cert/internal/cert_issuer_source_static.cc

+++ b/net/cert/internal/cert_issuer_source_static.cc

@@ -16,9 +16,8 @@ void CertIssuerSourceStatic::AddCert(scoped_refptr<ParsedCertificate> cert) {

cert->normalized_subject().AsStringPiece(), std::move(cert)));

}

-void CertIssuerSourceStatic::SyncGetIssuersOf(

- const ParsedCertificate* cert,

- std::vector<scoped_refptr<ParsedCertificate>>* issuers) {

+void CertIssuerSourceStatic::SyncGetIssuersOf(const ParsedCertificate* cert,

+ ParsedCertificateList* issuers) {

auto range =

intermediates_.equal_range(cert->normalized_issuer().AsStringPiece());

for (auto it = range.first; it != range.second; ++it)