Certificate path builder for new certificate verification library

net/cert/internal/cert_issuer_source.h

Index: net/cert/internal/cert_issuer_source.h
diff --git a/net/cert/internal/cert_issuer_source.h b/net/cert/internal/cert_issuer_source.h
index 61580a80f48fbdd990ed8c4611e13ea5a5468600..03269bb1dee2bcd31a49c554a939afb3a046a60b 100644
--- a/net/cert/internal/cert_issuer_source.h
+++ b/net/cert/internal/cert_issuer_source.h
@@ -15,6 +15,7 @@
 namespace net {
 
 class ParsedCertificate;
+using ParsedCertificateList = std::vector<scoped_refptr<ParsedCertificate>>;

[eroman, 2016/07/01 23:49:29]

Are you duplicating the definition here to avoid #include-ing
parsed_certificate.h?

I think it would be better to just #include it and have the one definition.

[mattm, 2016/07/02 02:21:51]

Yeah.
 
Done.

 
 // Interface for looking up issuers of a certificate during path building.
 // Provides a synchronous and asynchronous method for retrieving issuers, so the
@@ -58,9 +59,8 @@ class NET_EXPORT CertIssuerSource {
   // Matches are appended to |issuers|. Any existing contents of |issuers| will
   // not be modified. If the implementation does not support synchronous
   // lookups, or if there are no matches, |issuers| is not modified.
-  virtual void SyncGetIssuersOf(
-      const ParsedCertificate* cert,
-      std::vector<scoped_refptr<ParsedCertificate>>* issuers) = 0;
+  virtual void SyncGetIssuersOf(const ParsedCertificate* cert,
+                                ParsedCertificateList* issuers) = 0;
 
   // Finds certificates whose Subject matches |cert|'s Issuer.
   // If an async callback will be made |*out_req| is filled with a Request