components/cast_certificate/cast_cert_validator.h - Issue 1923433002: Certificate path builder for new certificate verification library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cast_certificate/cast_cert_validator.h

Issue 1923433002: Certificate path builder for new certificate verification library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changes for comment #16 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/cast_certificate/cast_cert_validator.h

diff --git a/components/cast_certificate/cast_cert_validator.h b/components/cast_certificate/cast_cert_validator.h

index 1c335ae6530b446a86bf234d00ac39f5774a0c7f..4d1344fedbd035cfe1d57afc1314fb919c2effa3 100644

--- a/components/cast_certificate/cast_cert_validator.h

+++ b/components/cast_certificate/cast_cert_validator.h

@@ -55,8 +55,7 @@ class CertVerificationContext {

// * |certs| is a chain of DER-encoded certificates:

// * |certs[0]| is the target certificate (i.e. the device certificate)

-// * |certs[i]| is the certificate that issued certs[i-1]

-// * |certs.back()| must be signed by a trust anchor

+// * |certs[1..n-1]| are intermediates certificates to use in path building.

eroman 2016/07/01 23:49:29 "Their ordering does not matter".

mattm 2016/07/02 02:21:51 Done.

// * |time| is the UTC time to use for determining if the certificate

// is expired.

« no previous file with comments | « no previous file | components/cast_certificate/cast_cert_validator.cc » ('j') | net/cert/internal/cert_issuer_source.h » ('J')