Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1923393002: Revert of Enable flattening of SkRecordedDrawable (Closed)

Created:
4 years, 7 months ago by mtklein
Modified:
4 years, 7 months ago
Reviewers:
msarett, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Enable flattening of SkRecordedDrawable (patchset #8 id:140001 of https://codereview.chromium.org/1913843002/ ) Reason for revert: Release mode bots appear to be crashing while loading .skp files in nanobench. Original issue's description: > Enable flattening of SkRecordedDrawable > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913843002 > > Committed: https://skia.googlesource.com/skia/+/d636950e8ecba89c0021ce4e76037c67aa6ee2cd TBR=djsollen@google.com,reed@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/569b02151f399628b0c0c0ca825dfe7b6e2795e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -285 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkGlobalInitialization_core.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M src/core/SkPictureData.h View 4 chunks +0 lines, -10 lines 0 comments Download
M src/core/SkPictureData.cpp View 6 chunks +0 lines, -37 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/core/SkPictureRecord.h View 4 chunks +0 lines, -7 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 3 chunks +0 lines, -29 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 2 chunks +60 lines, -1 line 0 comments Download
D src/core/SkRecordedDrawable.h View 1 chunk +0 lines, -43 lines 0 comments Download
D src/core/SkRecordedDrawable.cpp View 1 chunk +0 lines, -102 lines 0 comments Download
M tests/FlattenDrawableTest.cpp View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of Enable flattening of SkRecordedDrawable
4 years, 7 months ago (2016-04-27 16:29:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923393002/1
4 years, 7 months ago (2016-04-27 16:29:30 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 16:29:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/569b02151f399628b0c0c0ca825dfe7b6e2795e1

Powered by Google App Engine
This is Rietveld 408576698