Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: src/core/SkRecordedDrawable.cpp

Issue 1923393002: Revert of Enable flattening of SkRecordedDrawable (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkRecordedDrawable.h ('k') | tests/FlattenDrawableTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkRecordedDrawable.cpp
diff --git a/src/core/SkRecordedDrawable.cpp b/src/core/SkRecordedDrawable.cpp
deleted file mode 100644
index 9b5874f9272865047d0b58a770e4f2b0ddeca70b..0000000000000000000000000000000000000000
--- a/src/core/SkRecordedDrawable.cpp
+++ /dev/null
@@ -1,102 +0,0 @@
-/*
- * Copyright 2016 Google Inc.
- *
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-#include "SkLayerInfo.h"
-#include "SkMatrix.h"
-#include "SkPictureData.h"
-#include "SkPicturePlayback.h"
-#include "SkPictureRecord.h"
-#include "SkPictureRecorder.h"
-#include "SkPictureUtils.h"
-#include "SkRecordedDrawable.h"
-#include "SkRecordDraw.h"
-
-void SkRecordedDrawable::onDraw(SkCanvas* canvas) {
- SkDrawable* const* drawables = nullptr;
- int drawableCount = 0;
- if (fDrawableList) {
- drawables = fDrawableList->begin();
- drawableCount = fDrawableList->count();
- }
- SkRecordDraw(*fRecord, canvas, nullptr, drawables, drawableCount, fBBH, nullptr/*callback*/);
-}
-
-SkPicture* SkRecordedDrawable::onNewPictureSnapshot() {
- SkBigPicture::SnapshotArray* pictList = nullptr;
- if (fDrawableList) {
- // TODO: should we plumb-down the BBHFactory and recordFlags from our host
- // PictureRecorder?
- pictList = fDrawableList->newDrawableSnapshot();
- }
-
- SkAutoTUnref<SkLayerInfo> saveLayerData;
- if (fBBH && fDoSaveLayerInfo) {
- // TODO: can we avoid work by not allocating / filling these bounds?
- SkAutoTMalloc<SkRect> scratchBounds(fRecord->count());
- saveLayerData.reset(new SkLayerInfo);
-
- SkRecordComputeLayers(fBounds, *fRecord, scratchBounds, pictList, saveLayerData);
- }
-
- size_t subPictureBytes = 0;
- for (int i = 0; pictList && i < pictList->count(); i++) {
- subPictureBytes += SkPictureUtils::ApproximateBytesUsed(pictList->begin()[i]);
- }
- // SkBigPicture will take ownership of a ref on both fRecord and fBBH.
- // We're not willing to give up our ownership, so we must ref them for SkPicture.
- return new SkBigPicture(fBounds, SkRef(fRecord.get()), pictList, SkSafeRef(fBBH.get()),
- saveLayerData.release(), subPictureBytes);
-}
-
-void SkRecordedDrawable::flatten(SkWriteBuffer& buffer) const {
- // Write the bounds.
- buffer.writeRect(fBounds);
-
- // Create an SkPictureRecord to record the draw commands.
- SkPictInfo info;
- SkPictureRecord pictureRecord(SkISize::Make(fBounds.width(), fBounds.height()), 0);
-
- // If the query contains the whole picture, don't bother with the bounding box hierarchy.
- SkRect clipBounds;
- pictureRecord.getClipBounds(&clipBounds);
- SkBBoxHierarchy* bbh;
- if (clipBounds.contains(fBounds)) {
- bbh = nullptr;
- } else {
- bbh = fBBH.get();
- }
-
- // Record the draw commands.
- pictureRecord.beginRecording();
- SkRecordDraw(*fRecord, &pictureRecord, nullptr, fDrawableList->begin(), fDrawableList->count(),
- bbh, nullptr);
- pictureRecord.endRecording();
-
- // Flatten the recorded commands and drawables.
- SkPictureData pictureData(pictureRecord, info, false);
- pictureData.flatten(buffer);
-}
-
-sk_sp<SkFlattenable> SkRecordedDrawable::CreateProc(SkReadBuffer& buffer) {
- // Read the bounds.
- SkRect bounds;
- buffer.readRect(&bounds);
-
- // Unflatten into a SkPictureData.
- SkPictInfo info;
- info.fCullRect = bounds;
- SkAutoTDelete<SkPictureData> pictureData(SkPictureData::CreateFromBuffer(buffer, info));
- if (!pictureData) {
- return nullptr;
- }
-
- // Create a drawable.
- SkPicturePlayback playback(pictureData);
- SkPictureRecorder recorder;
- playback.draw(recorder.beginRecording(bounds), nullptr, &buffer);
- return recorder.finishRecordingAsDrawable();
-}
« no previous file with comments | « src/core/SkRecordedDrawable.h ('k') | tests/FlattenDrawableTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698