Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9130)

Unified Diff: build_overrides/pdfium.gni

Issue 1923343002: Add PDFium build_overrides (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_overrides/pdfium.gni
diff --git a/third_party/leakcanary/config.gni b/build_overrides/pdfium.gni
similarity index 65%
copy from third_party/leakcanary/config.gni
copy to build_overrides/pdfium.gni
index f6adcddf3ecc4442c7793666dfeecaf1f108fea8..d492919a6f549216cdbb9b5ed246d1902ed7b062 100644
--- a/third_party/leakcanary/config.gni
+++ b/build_overrides/pdfium.gni
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-declare_args() {
- enable_leakcanary = false
-}
+import("//third_party/pdfium/pdfium.gni")
+
+pdf_enable_v8 = true
+pdf_enable_xfa = false
Nico 2016/04/27 16:44:12 do you want to have this set to false on your bots
dsinclair 2016/04/27 16:47:41 This is the Chromium side change, our bots don't u
Nico 2016/04/27 16:52:15 ooh I see. Then shouldn't the cr side not include
« no previous file with comments | « no previous file | pdf/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698