build_overrides/pdfium.gni - Issue 1923343002: Add PDFium build_overrides

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build_overrides/pdfium.gni

Issue 1923343002: Add PDFium build_overrides (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 declare_args() {	5 import("//third_party/pdfium/pdfium.gni")

6 enable_leakcanary = false	6

7 }	7 pdf_enable_v8 = true

	8 pdf_enable_xfa = false
	Nico 2016/04/27 16:44:12 do you want to have this set to false on your bots do you want to have this set to false on your bots? or do you want this to be an arg in pdfium builds? dsinclair 2016/04/27 16:47:41 This is the Chromium side change, our bots don't u Show quoted text On 2016/04/27 16:44:12, Nico wrote: > do you want to have this set to false on your bots? or do you want this to be an > arg in pdfium builds? This is the Chromium side change, our bots don't use Chromium to test so this shouldn't effect our bot runs. Yea? Nico 2016/04/27 16:52:15 ooh I see. Then shouldn't the cr side not include Show quoted text On 2016/04/27 16:47:41, dsinclair wrote: > On 2016/04/27 16:44:12, Nico wrote: > > do you want to have this set to false on your bots? or do you want this to be > an > > arg in pdfium builds? > > This is the Chromium side change, our bots don't use Chromium to test so this > shouldn't effect our bot runs. Yea? ooh I see. Then shouldn't the cr side not include the gni file but just set the values we want for everything in chromium? And shouldn't the pdfium side not use an include of pdfium.gni but move the contents of pdfium.gni to the new file? We probably don't want all these declare_args in a Chromium build, right?
OLD	NEW

« no previous file with comments | « no previous file | pdf/BUILD.gn » ('j') | no next file with comments »