Allow overriding GN build flags

Allow overriding GN build flags

In order to enable XFA from GN builds we need to be able to override
pdf_enable_xfa. To do this a build_overrides/pdfium.gni file needs to be created
in Chrome. To use that, we have to create a build_overrides/pdfium.gni file
in PDFium that just uses the default values.

BUG=chromium:62400
Committed: https://pdfium.googlesource.com/pdfium/+/1ae572e7e35b52ce4897d1715c005a1b0f79526a

[dsinclair, 2016-04-27 14:12:17]

Description was changed from

==========
Allow overriding GN build flags

In order to enable XFA from GN builds we need to be able to override
pdf_enable_xfa. To do this a build_overrides/pdfium.gni file needs to be created
in Chrome. To use that, we have to create a build_overrides/pdfium.gni file
in PDFium that just uses the default values.
==========

to

==========
Allow overriding GN build flags

In order to enable XFA from GN builds we need to be able to override
pdf_enable_xfa. To do this a build_overrides/pdfium.gni file needs to be created
in Chrome. To use that, we have to create a build_overrides/pdfium.gni file
in PDFium that just uses the default values.

BUG=62400
==========

[dsinclair, 2016-04-27 14:12:59]

Description was changed from

==========
Allow overriding GN build flags

In order to enable XFA from GN builds we need to be able to override
pdf_enable_xfa. To do this a build_overrides/pdfium.gni file needs to be created
in Chrome. To use that, we have to create a build_overrides/pdfium.gni file
in PDFium that just uses the default values.

BUG=62400
==========

to

==========
Allow overriding GN build flags

In order to enable XFA from GN builds we need to be able to override
pdf_enable_xfa. To do this a build_overrides/pdfium.gni file needs to be created
in Chrome. To use that, we have to create a build_overrides/pdfium.gni file
in PDFium that just uses the default values.

BUG=chromium:62400
==========

[dsinclair, 2016-04-27 14:20:23]

dsinclair@chromium.org changed reviewers:
+ thakis@chromium.org

[dsinclair, 2016-04-27 14:20:24]

PTAL.

I need to be able to flip the pdf_enable_xfa flag defined in pdfium.gni from a
chrome build. I think this is the right way to do it?

The chrome side change is at: https://codereview.chromium.org/1923343002/ which
I'll add the DEPS roll into once this lands.

[Nico, 2016-04-27 16:43:29]

https://codereview.chromium.org/1923333002/diff/1/build_overrides/pdfium.gni
File build_overrides/pdfium.gni (right):

https://codereview.chromium.org/1923333002/diff/1/build_overrides/pdfium.gni#...
build_overrides/pdfium.gni:5: import("../pdfium.gni")
From what I understand, this file should set the pdfium variables controlling
xfa and stuff to the values it should have in Chromium. The pdfium version of
this file should set them to the value they should have in pdfium.

So having this file be empty looks wrong to me.

[dsinclair, 2016-04-27 16:49:59]

https://codereview.chromium.org/1923333002/diff/1/build_overrides/pdfium.gni
File build_overrides/pdfium.gni (right):

https://codereview.chromium.org/1923333002/diff/1/build_overrides/pdfium.gni#...
build_overrides/pdfium.gni:5: import("../pdfium.gni")
On 2016/04/27 16:43:29, Nico wrote:
> From what I understand, this file should set the pdfium variables controlling
> xfa and stuff to the values it should have in Chromium. The pdfium version of
> this file should set them to the value they should have in pdfium.
> 
> So having this file be empty looks wrong to me.


So, the values we want in PDFium are the default values set in pdfium.gni. I had
to add this file because the other BUILD.gn files reference
build_overrides/pdfium.gni so it will get picked up in the Chrome build.

If the PDFium files referenced ../pdfium.gni and the Chrome files used
build_overrides/pdfium.gni I ended up with different flags set in different
places (i.e. the third_party/BUILD.gn had pdf_enable_xfa=false when other files
had it as true.)

[Nico, 2016-04-27 19:38:21]

lgtm

[dsinclair, 2016-04-27 19:39:17]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-27 19:39:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1923333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1923333002/20001

[commit-bot: I haz the power, 2016-04-27 20:02:26]

Description was changed from

==========
Allow overriding GN build flags

In order to enable XFA from GN builds we need to be able to override
pdf_enable_xfa. To do this a build_overrides/pdfium.gni file needs to be created
in Chrome. To use that, we have to create a build_overrides/pdfium.gni file
in PDFium that just uses the default values.

BUG=chromium:62400
==========

to

==========
Allow overriding GN build flags

In order to enable XFA from GN builds we need to be able to override
pdf_enable_xfa. To do this a build_overrides/pdfium.gni file needs to be created
in Chrome. To use that, we have to create a build_overrides/pdfium.gni file
in PDFium that just uses the default values.

BUG=chromium:62400

Committed:
https://pdfium.googlesource.com/pdfium/+/1ae572e7e35b52ce4897d1715c005a1b0f79...
==========

[commit-bot: I haz the power, 2016-04-27 20:02:27]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/1ae572e7e35b52ce4897d1715c005a1b0f79...

[Oliver Chang, 2016-04-30 01:08:44]

On 2016/04/27 20:02:27, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://pdfium.googlesource.com/pdfium/+/1ae572e7e35b52ce4897d1715c005a1b0f79...

Looks like this is breaking rolls :( -
https://codereview.chromium.org/1942533002/

[dsinclair, 2016-04-30 12:47:45]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1941563002/ by dsinclair@chromium.org.

The reason for reverting is: Blocking the roll
.

[dsinclair, 2016-04-30 12:48:15]

On 2016/04/30 01:08:44, Oliver Chang wrote:
> On 2016/04/27 20:02:27, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:20001) as
> >
>
https://pdfium.googlesource.com/pdfium/+/1ae572e7e35b52ce4897d1715c005a1b0f79...
> 
> Looks like this is breaking rolls :( -
> https://codereview.chromium.org/1942533002/

Sorry, the other half of this CL got reverted from the chromium tree. Sent
revert for this CL.