build_overrides/pdfium.gni - Issue 1923333002: Allow overriding GN build flags

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build_overrides/pdfium.gni

Issue 1923333002: Allow overriding GN build flags (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("../pdfium.gni")
	Nico 2016/04/27 16:43:29 From what I understand, this file should set the p From what I understand, this file should set the pdfium variables controlling xfa and stuff to the values it should have in Chromium. The pdfium version of this file should set them to the value they should have in pdfium. So having this file be empty looks wrong to me. dsinclair 2016/04/27 16:49:59 So, the values we want in PDFium are the default v Show quoted text On 2016/04/27 16:43:29, Nico wrote: > From what I understand, this file should set the pdfium variables controlling > xfa and stuff to the values it should have in Chromium. The pdfium version of > this file should set them to the value they should have in pdfium. > > So having this file be empty looks wrong to me. So, the values we want in PDFium are the default values set in pdfium.gni. I had to add this file because the other BUILD.gn files reference build_overrides/pdfium.gni so it will get picked up in the Chrome build. If the PDFium files referenced ../pdfium.gni and the Chrome files used build_overrides/pdfium.gni I ended up with different flags set in different places (i.e. the third_party/BUILD.gn had pdf_enable_xfa=false when other files had it as true.)
OLD	NEW

« no previous file with comments | « BUILD.gn ('k') | samples/BUILD.gn » ('j') | no next file with comments »