Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1923323002: Fixed first step of scrolling not applying (Closed)

Created:
4 years, 7 months ago by bokan
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fixed first step of scrolling not applying I fixed the first step of scrolling not applying when switching from one slave mouse device to another. This bug was happening because the Xinput2 event XIDeviceChangedEvent is used for two different reasons, a device's properties changing and the current slave device being switched. This code checks that the reason field is set to XIDeviceChange (rather than XISlaveSwitch). BUG=593453 Review URL: https://codereview.chromium.org/1883853002 Cr-Commit-Position: refs/heads/master@{#388182} (cherry picked from commit 47c6f3e7252ece9b52e5b86d40944e66442ea7aa) Committed: https://chromium.googlesource.com/chromium/src/+/62bcee1fab7fde7b93fe299f13f168bb73812b46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/events/platform/x11/x11_event_source.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
bokan
4 years, 7 months ago (2016-04-27 13:49:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
62bcee1fab7fde7b93fe299f13f168bb73812b46.

Powered by Google App Engine
This is Rietveld 408576698