Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1883853002: Fixed first step of scrolling not applying (Closed)

Created:
4 years, 8 months ago by Will Shackleton
Modified:
4 years, 8 months ago
Reviewers:
taviso1, sadrul, bokan
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed first step of scrolling not applying I fixed the first step of scrolling not applying when switching from one slave mouse device to another. This bug was happening because the Xinput2 event XIDeviceChangedEvent is used for two different reasons, a device's properties changing and the current slave device being switched. This code checks that the reason field is set to XIDeviceChange (rather than XISlaveSwitch). BUG=593453 Committed: https://crrev.com/47c6f3e7252ece9b52e5b86d40944e66442ea7aa Cr-Commit-Position: refs/heads/master@{#388182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/events/platform/x11/x11_event_source.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Will Shackleton
4 years, 8 months ago (2016-04-13 19:40:42 UTC) #4
Will Shackleton
Have a look at https://people.freedesktop.org/~whot/xi2-recipes/part3.c lines 131--145 for some other code using this logic. I ...
4 years, 8 months ago (2016-04-15 16:17:58 UTC) #5
sadrul
lgtm
4 years, 8 months ago (2016-04-19 01:24:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883853002/1
4 years, 8 months ago (2016-04-19 10:22:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 11:14:08 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 11:15:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47c6f3e7252ece9b52e5b86d40944e66442ea7aa
Cr-Commit-Position: refs/heads/master@{#388182}

Powered by Google App Engine
This is Rietveld 408576698