Clean net_test_support_data_sources and net_unittests_data_source.

Clean net_test_support_data_sources and net_unittests_data_source.

Since http://crrev.com/1896903002 net/net.gypi explicitly list all
files that should be used by the corresponding tests targets on iOS.
Original CL incorrectly listed python and shell script there. Remove
them.

Add a script net/data/update_net_gypi.py to automate updating those
variables in net/net.gypi.

BUG=None

Committed: https://crrev.com/e1a48058c0e8652558fbc566e8dc2a5d19063580
Cr-Commit-Position: refs/heads/master@{#391075}

[sdefresne, 2016-04-27 08:59:05]

sdefresne@chromium.org changed reviewers:
+ eroman@chromium.org

[sdefresne, 2016-04-27 08:59:06]

Please take a look. This is a followup to
https://codereview.chromium.org/1896903002/.

[eroman, 2016-04-27 16:23:14]

lgtm, thanks!

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
File net/data/update_net_gypi.py (right):

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:10: import cStringIO as StringIO
I would remove this and just import StringIO -- I don't think this level of
optimization for this kind of script is necessary.

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:16: EXCLUSION_PATTERN =
re.compile("^(?:README|OWNERS|.*\.(pyc?|sh))$")
Can also exclude editor swap files:

*.swp
*~

When I ran the script in the past turned out I had some open files and they got
added too :)

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:38: def RelativePath(dir, path):
style: functions_are_like_this() --
https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming

This applies throughout.

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:39: """Converts |path| to be relative to |dir|.
Can you use os.path.relpath() ?

Or alternately use relative paths throughout, and only join the paths when
needed for file operations.

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:129: file.write(buffer.getvalue())
nit: I suggest including an output message from the script indicating what file
was written to.

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:133: root_dir =
os.path.normpath(os.path.join(os.path.dirname(__file__), "../.."))
nit: rather than "../../" would be more general to call os.path.dirname() twice.
Or join with os.pardir.

[sdefresne, 2016-04-30 12:31:41]

Please take another look (and send to CQ if no additional comments).

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
File net/data/update_net_gypi.py (right):

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:10: import cStringIO as StringIO
On 2016/04/27 at 16:23:14, eroman wrote:
> I would remove this and just import StringIO -- I don't think this level of
optimization for this kind of script is necessary.

Done.

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:16: EXCLUSION_PATTERN =
re.compile("^(?:README|OWNERS|.*\.(pyc?|sh))$")
On 2016/04/27 at 16:23:14, eroman wrote:
> Can also exclude editor swap files:
> 
> *.swp
> *~
> 
> When I ran the script in the past turned out I had some open files and they
got added too :)

Done.

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:38: def RelativePath(dir, path):
On 2016/04/27 at 16:23:14, eroman wrote:
> style: functions_are_like_this() --
https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming
> 
> This applies throughout.

Done.

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:39: """Converts |path| to be relative to |dir|.
On 2016/04/27 at 16:23:14, eroman wrote:
> Can you use os.path.relpath() ?
> 
> Or alternately use relative paths throughout, and only join the paths when
needed for file operations.

Done.

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:129: file.write(buffer.getvalue())
On 2016/04/27 at 16:23:14, eroman wrote:
> nit: I suggest including an output message from the script indicating what
file was written to.

Done.

https://codereview.chromium.org/1923203002/diff/20001/net/data/update_net_gyp...
net/data/update_net_gypi.py:133: root_dir =
os.path.normpath(os.path.join(os.path.dirname(__file__), "../.."))
On 2016/04/27 at 16:23:14, eroman wrote:
> nit: rather than "../../" would be more general to call os.path.dirname()
twice. Or join with os.pardir.

Done.

[eroman, 2016-05-02 21:09:57]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-05-02 21:09:58]

lgtm

[commit-bot: I haz the power, 2016-05-02 21:15:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1923203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1923203002/40001

[commit-bot: I haz the power, 2016-05-02 22:25:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-02 22:27:09]

Description was changed from

==========
Clean net_test_support_data_sources and net_unittests_data_source.

Since http://crrev.com/1896903002 net/net.gypi explicitly list all
files that should be used by the corresponding tests targets on iOS.
Original CL incorrectly listed python and shell script there. Remove
them.

Add a script net/data/update_net_gypi.py to automate updating those
variables in net/net.gypi.

BUG=None
==========

to

==========
Clean net_test_support_data_sources and net_unittests_data_source.

Since http://crrev.com/1896903002 net/net.gypi explicitly list all
files that should be used by the corresponding tests targets on iOS.
Original CL incorrectly listed python and shell script there. Remove
them.

Add a script net/data/update_net_gypi.py to automate updating those
variables in net/net.gypi.

BUG=None

Committed: https://crrev.com/e1a48058c0e8652558fbc566e8dc2a5d19063580
Cr-Commit-Position: refs/heads/master@{#391075}
==========

[commit-bot: I haz the power, 2016-05-02 22:27:10]

Patchset 3 (id:??) landed as
https://crrev.com/e1a48058c0e8652558fbc566e8dc2a5d19063580
Cr-Commit-Position: refs/heads/master@{#391075}