Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/net.gypi

Issue 1923203002: Clean net_test_support_data_sources and net_unittests_data_source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@{interstitial}
Patch Set: Address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/data/update_net_gypi.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/net.gypi
diff --git a/net/net.gypi b/net/net.gypi
index 657582f7f57badb51e428ebc4c1a4e0277d43d1f..a43db067eebd634481711518df0c4c8be208d5df 100644
--- a/net/net.gypi
+++ b/net/net.gypi
@@ -1969,12 +1969,8 @@
"websockets/websocket_stream.cc",
"websockets/websocket_stream.h",
],
- # List of test data files for //net:test_support. Can be regenerated with
- # the following command:
- #
- # for path in net/data/ssl/certificates; do
- # find "$path" -type f ! -name README -o -name OWNERS
- # done|sed -e "s:^net/\(.*\): '\1',:"|sort
+ # List of test data files for //net:test_support. Can be regenerated by
+ # running net/data/update_net_gypi.py.
'net_test_support_data_sources': [
'data/ssl/certificates/1024-rsa-ee-by-1024-rsa-intermediate.pem',
'data/ssl/certificates/1024-rsa-ee-by-2048-rsa-intermediate.pem',
@@ -2148,26 +2144,11 @@
'data/ssl/certificates/www_us_army_mil_cert.der',
'data/ssl/certificates/x509_verify_results.chain.pem',
],
- # List of test data files for //net:net_unittests. Can be regenerated with
- # the following command:
- #
- # for path in net/data/certificate_policies_unittest \
- # net/data/name_constraints_unittest \
- # net/data/parse_certificate_unittest \
- # net/data/parse_ocsp_unittest \
- # net/data/test.html \
- # net/data/url_request_unittest \
- # net/data/verify_certificate_chain_unittest \
- # net/data/verify_name_match_unittest/names \
- # net/data/verify_signed_data_unittest \
- # net/third_party/nist-pkits/certs \
- # net/third_party/nist-pkits/crls; do
- # find "$path" -type f ! -name README -o -name OWNERS
- # done|sed -e "s:^net/\(.*\): '\1',:"|sort
+ # List of test data files for //net:net_unittests. Can be regenerated by
+ # running net/data/update_net_gypi.py.
'net_unittests_data_sources': [
'data/certificate_policies_unittest/anypolicy.pem',
'data/certificate_policies_unittest/anypolicy_with_qualifier.pem',
- 'data/certificate_policies_unittest/generate_policies.py',
'data/certificate_policies_unittest/invalid-anypolicy_with_custom_qualifier.pem',
'data/certificate_policies_unittest/invalid-empty.pem',
'data/certificate_policies_unittest/invalid-policy_1_2_3_dupe.pem',
@@ -2198,7 +2179,6 @@
'data/name_constraints_unittest/dnsname2.pem',
'data/name_constraints_unittest/edipartyname-excluded.pem',
'data/name_constraints_unittest/edipartyname-permitted.pem',
- 'data/name_constraints_unittest/generate_name_constraints.py',
'data/name_constraints_unittest/invalid-empty_excluded_subtree.pem',
'data/name_constraints_unittest/invalid-empty_permitted_subtree.pem',
'data/name_constraints_unittest/invalid-no_subtrees.pem',
@@ -2309,7 +2289,6 @@
'data/parse_certificate_unittest/tbs_validity_generalized_time_and_utc_time.pem',
'data/parse_certificate_unittest/tbs_validity_relaxed.pem',
'data/parse_certificate_unittest/tbs_validity_utc_time_and_generalized_time.pem',
- 'data/parse_ocsp_unittest/annotate_test_data.py',
'data/parse_ocsp_unittest/bad_ocsp_type.pem',
'data/parse_ocsp_unittest/bad_signature.pem',
'data/parse_ocsp_unittest/bad_status.pem',
@@ -2393,34 +2372,10 @@
'data/url_request_unittest/with-headers.html',
'data/url_request_unittest/with-headers.html.mock-http-headers',
'data/verify_certificate_chain_unittest/basic-constraints-pathlen-0-self-issued.pem',
- 'data/verify_certificate_chain_unittest/common.py',
'data/verify_certificate_chain_unittest/expired-intermediary.pem',
'data/verify_certificate_chain_unittest/expired-root.pem',
'data/verify_certificate_chain_unittest/expired-target-notBefore.pem',
'data/verify_certificate_chain_unittest/expired-target.pem',
- 'data/verify_certificate_chain_unittest/generate-all.sh',
- 'data/verify_certificate_chain_unittest/generate-basic-constraints-pathlen-0-self-issued.py',
- 'data/verify_certificate_chain_unittest/generate-expired-intermediary.py',
- 'data/verify_certificate_chain_unittest/generate-expired-target-notBefore.py',
- 'data/verify_certificate_chain_unittest/generate-expired-target.py',
- 'data/verify_certificate_chain_unittest/generate-intermediary-basic-constraints-ca-false.py',
- 'data/verify_certificate_chain_unittest/generate-intermediary-basic-constraints-not-critical.py',
- 'data/verify_certificate_chain_unittest/generate-intermediary-lacks-basic-constraints.py',
- 'data/verify_certificate_chain_unittest/generate-intermediary-lacks-signing-key-usage.py',
- 'data/verify_certificate_chain_unittest/generate-intermediary-signed-with-md5.py',
- 'data/verify_certificate_chain_unittest/generate-intermediary-unknown-critical-extension.py',
- 'data/verify_certificate_chain_unittest/generate-intermediary-unknown-non-critical-extension.py',
- 'data/verify_certificate_chain_unittest/generate-target-and-intermediary.py',
- 'data/verify_certificate_chain_unittest/generate-target-has-keycertsign-but-not-ca.py',
- 'data/verify_certificate_chain_unittest/generate-target-has-pathlen-but-not-ca.py',
- 'data/verify_certificate_chain_unittest/generate-target-not-end-entity.py',
- 'data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py',
- 'data/verify_certificate_chain_unittest/generate-target-signed-using-ecdsa.py',
- 'data/verify_certificate_chain_unittest/generate-target-signed-with-md5.py',
- 'data/verify_certificate_chain_unittest/generate-target-unknown-critical-extension.py',
- 'data/verify_certificate_chain_unittest/generate-target-wrong-signature.py',
- 'data/verify_certificate_chain_unittest/generate-unknown-root.py',
- 'data/verify_certificate_chain_unittest/generate-violates-basic-constraints-pathlen-0.py',
'data/verify_certificate_chain_unittest/intermediary-basic-constraints-ca-false.pem',
'data/verify_certificate_chain_unittest/intermediary-basic-constraints-not-critical.pem',
'data/verify_certificate_chain_unittest/intermediary-lacks-basic-constraints.pem',
@@ -2431,7 +2386,6 @@
'data/verify_certificate_chain_unittest/issuer-and-subject-not-byte-for-byte-equal-anchor.pem',
'data/verify_certificate_chain_unittest/issuer-and-subject-not-byte-for-byte-equal.pem',
'data/verify_certificate_chain_unittest/non-self-signed-root.pem',
- 'data/verify_certificate_chain_unittest/openssl_conf.py',
'data/verify_certificate_chain_unittest/target-and-intermediary.pem',
'data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem',
'data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem',
@@ -2525,7 +2479,6 @@
'data/verify_name_match_unittest/names/unicode_supplementary-UTF8-unmangled.pem',
'data/verify_name_match_unittest/names/valid-Name-empty.pem',
'data/verify_name_match_unittest/names/valid-minimal.pem',
- 'data/verify_signed_data_unittest/annotate_test_data.py',
'data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-spki-params-null.pem',
'data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-unused-bits-signature.pem',
'data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-using-ecdh-key.pem',
« no previous file with comments | « net/data/update_net_gypi.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698