Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1923153002: CPDF_Document::LoadPattern() and friends always have a valid matrix. (Closed)

Created:
4 years, 8 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@clean_doc2
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

CPDF_Document::LoadPattern() and friends always have a valid matrix. So pass by const-ref instead of by pointer. Committed: https://pdfium.googlesource.com/pdfium/+/12168d764be266a209bc3fd15dbe4223732ae319

Patch Set 1 #

Patch Set 2 : const #

Patch Set 3 : more #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -144 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_form.cpp View 1 2 chunks +8 lines, -10 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pattern.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pattern.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_shadingpattern.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_shadingpattern.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_tilingpattern.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_tilingpattern.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 2 9 chunks +73 lines, -15 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
D core/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_form.h View 1 1 chunk +7 lines, -6 lines 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_document.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
4 years, 8 months ago (2016-04-27 00:51:29 UTC) #2
dsinclair
lgtm
4 years, 7 months ago (2016-04-27 03:00:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923153002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923153002/60001
4 years, 7 months ago (2016-04-27 05:33:55 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 05:41:40 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/12168d764be266a209bc3fd15dbe4223732a...

Powered by Google App Engine
This is Rietveld 408576698