Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: ui/views/bubble/bubble_frame_view.h

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix namespace in .h and other minor review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/resources/ui_resources.grd ('K') | « ui/resources/ui_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_frame_view.h
diff --git a/ui/views/bubble/bubble_frame_view.h b/ui/views/bubble/bubble_frame_view.h
index 6f92883c13b51247507b4d984196bac827e19c86..62d9b8636f88e4b2c7bd1b667c545b9d6e1871ac 100644
--- a/ui/views/bubble/bubble_frame_view.h
+++ b/ui/views/bubble/bubble_frame_view.h
@@ -16,6 +16,8 @@ namespace gfx {
class FontList;
}
+FORWARD_DECLARE_TEST(TranslateBubbleViewTest, CloseButtonIn2016Q2UI);
+
namespace views {
class Label;
@@ -96,6 +98,7 @@ class VIEWS_EXPORT BubbleFrameView : public NonClientFrameView,
FRIEND_TEST_ALL_PREFIXES(BubbleFrameViewTest, GetBoundsForClientView);
FRIEND_TEST_ALL_PREFIXES(BubbleDelegateTest, CloseReasons);
FRIEND_TEST_ALL_PREFIXES(BubbleDialogDelegateTest, CloseMethods);
+ FRIEND_TEST_ALL_PREFIXES(::TranslateBubbleViewTest, CloseButtonIn2016Q2UI);
msw 2016/04/29 20:00:03 Can you avoid this and instead fire an [Escape] ke
ftang 2016/04/29 22:37:03 no, I cannot.
msw 2016/04/29 23:43:40 Please explain why; it's unfortunate if we need to
// Mirrors the bubble's arrow location on the |vertical| or horizontal axis,
// if the generated window bounds don't fit in the monitor bounds.
« ui/resources/ui_resources.grd ('K') | « ui/resources/ui_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698