ui/resources/ui_resources.grd - Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/resources/ui_resources.grd

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix namespace in .h and other minor review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/translate/core/browser/translate_ui_delegate_unittest.cc ('K') | « ui/resources/default_100_percent/common/translate.png ('k') | ui/views/bubble/bubble_frame_view.h » ('j') | ui/views/bubble/bubble_frame_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/resources/ui_resources.grd

diff --git a/ui/resources/ui_resources.grd b/ui/resources/ui_resources.grd

index 0a53038b4169aa5a08e6fef91eb2811bfc219273..84634754514af926fee4e36ee8820f976bf46803 100644

--- a/ui/resources/ui_resources.grd

+++ b/ui/resources/ui_resources.grd

@@ -193,6 +193,7 @@

</if>

+ <structure type="chrome_scaled_image" name="IDR_TRANSLATE_ICON_V2" file="common/translate.png" />

msw 2016/04/29 20:00:03 There is no "IDR_TRANSLATE_ICON"... so I'm not sur

ftang 2016/04/29 22:37:03 I cannot drop _V2 because it will cause name confl

</structures>

</release>

</grit>