Issue 1923033002: Revert of Bug fix in sampling whitelisted download.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1923033002: Revert of Bug fix in sampling whitelisted download. (Closed)

Created:
4 years, 8 months ago by Jialiu Lin

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Bug fix in sampling whitelisted download. (patchset #1 id:1 of https://codereview.chromium.org/1918353002/ ) Reason for revert: Merge conflict unresolved Original issue's description: > Bug fix in sampling whitelisted download. > > BUG=553674 > > Review URL: https://codereview.chromium.org/1911543002 > > Cr-Commit-Position: refs/heads/master@{#388575} > (cherry picked from commit 2c43aa6abc22315875dc1ebf5de63ca8b1b3b791) > > Committed: https://chromium.googlesource.com/chromium/src/+/6f3d958d78e964f8f73030dd0eeb49b82f98b162 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=553674

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -8 lines)			Patch
	M	chrome/browser/safe_browsing/download_protection_service.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/safe_browsing/download_protection_service_unittest.cc	View		3 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jialiu Lin

Created Revert of Bug fix in sampling whitelisted download.

4 years, 8 months ago (2016-04-26 19:41:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923033002/1

4 years, 8 months ago (2016-04-26 19:41:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages