Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1911543002: Bug fix in sampling whitelisted download. (Closed)

Created:
4 years, 8 months ago by Jialiu Lin
Modified:
4 years, 8 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bug fix in sampling whitelisted download. BUG=553674 Committed: https://crrev.com/2c43aa6abc22315875dc1ebf5de63ca8b1b3b791 Cr-Commit-Position: refs/heads/master@{#388575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/safe_browsing/download_protection_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jialiu Lin
Hi nparker@, I made a silly mistake in my previous CL. Luckily it only impacted ...
4 years, 8 months ago (2016-04-20 19:42:44 UTC) #2
Nathan Parker
lgtm
4 years, 8 months ago (2016-04-20 19:45:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911543002/1
4 years, 8 months ago (2016-04-20 20:40:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 20:58:09 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:26:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2c43aa6abc22315875dc1ebf5de63ca8b1b3b791
Cr-Commit-Position: refs/heads/master@{#388575}

Powered by Google App Engine
This is Rietveld 408576698