Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5919)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1922993002: Remove the backspace/shift+backspace navigating the page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/constrained_window_views_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index fe8c83ef5cc8235e1cb3d251bbbdb321ce54450e..31d60e9faf16c5f73cc6ddc9d048b4e71141069e 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -2442,17 +2442,13 @@ void BrowserView::UpdateAcceleratorMetrics(const ui::Accelerator& accelerator,
// on Chrome OS.
switch (command_id) {
case IDC_BACK:
- if (key_code == ui::VKEY_BACK)
- content::RecordAction(UserMetricsAction("Accel_Back_Backspace"));
- else if (key_code == ui::VKEY_BROWSER_BACK)
+ if (key_code == ui::VKEY_BROWSER_BACK)
content::RecordAction(UserMetricsAction("Accel_Back_F1"));
else if (key_code == ui::VKEY_LEFT)
content::RecordAction(UserMetricsAction("Accel_Back_Left"));
break;
case IDC_FORWARD:
- if (key_code == ui::VKEY_BACK)
- content::RecordAction(UserMetricsAction("Accel_Forward_Backspace"));
- else if (key_code == ui::VKEY_BROWSER_FORWARD)
+ if (key_code == ui::VKEY_BROWSER_FORWARD)
content::RecordAction(UserMetricsAction("Accel_Forward_F2"));
else if (key_code == ui::VKEY_RIGHT)
content::RecordAction(UserMetricsAction("Accel_Forward_Right"));
« no previous file with comments | « chrome/browser/ui/views/constrained_window_views_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698