Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: chrome/browser/ui/views/constrained_window_views_browsertest.cc

Issue 1922993002: Remove the backspace/shift+backspace navigating the page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/accelerator_table.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/constrained_window_views_browsertest.cc
diff --git a/chrome/browser/ui/views/constrained_window_views_browsertest.cc b/chrome/browser/ui/views/constrained_window_views_browsertest.cc
index 0805734c735eaaaf3986616322e7161b28fd33d1..778f7df8b6644a05e7082d2017b2684336d58e2c 100644
--- a/chrome/browser/ui/views/constrained_window_views_browsertest.cc
+++ b/chrome/browser/ui/views/constrained_window_views_browsertest.cc
@@ -168,32 +168,6 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, TabMoveTest) {
EXPECT_EQ(NULL, dialog->GetWidget());
}
-// Tests that the web contents navigates when backspace is pressed.
-IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, NavigationOnBackspace) {
- content::WebContents* web_contents =
- browser()->tab_strip_model()->GetActiveWebContents();
- content::WaitForLoadStop(web_contents);
- const GURL original_url = web_contents->GetURL();
- EXPECT_NE(GURL(chrome::kChromeUIVersionURL), original_url);
- ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIVersionURL));
- content::WaitForLoadStop(web_contents);
- EXPECT_EQ(GURL(chrome::kChromeUIVersionURL), web_contents->GetURL());
-
- std::unique_ptr<TestDialog> dialog = ShowModalDialog(web_contents);
- EXPECT_TRUE(dialog->GetWidget()->IsVisible());
- EXPECT_EQ(dialog->GetContentsView(),
- dialog->GetWidget()->GetFocusManager()->GetFocusedView());
-
- // Pressing backspace should navigate back and close the dialog.
- EXPECT_TRUE(chrome::CanGoBack(browser()));
- EXPECT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_BACK,
- false, false, false, false));
- content::RunAllPendingInMessageLoop();
- content::WaitForLoadStop(web_contents);
- EXPECT_EQ(NULL, dialog->GetWidget());
- EXPECT_EQ(original_url, web_contents->GetURL());
-}
-
// Tests that the dialog closes when the escape key is pressed.
IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, ClosesOnEscape) {
#if defined(OS_WIN)
« no previous file with comments | « chrome/browser/ui/views/accelerator_table.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698