Make warn-unneeded-finalizer warning usable.

Make warn-unneeded-finalizer warning usable.

The Blink GC plugin option warn-unneeded-finalizer (enabled by including
"warn-unneeded-finalizer=1" in your  "blink_gc_plugin_flags" gyp defines)
is potentially useful in identifying classes which needlessly derive from
GarbageCollectedFinalized<> where GarbageCollected<> would do.

To avoid far too many false positives to make it practically useful on
the Blink codebase, make it be more forgiving about bases with virtual
destructors + recognize class declarations with
finalizeGarbageCollectedObject() methods defined. Neither of those
two cases should be reported as warnings.

R=
BUG=

Committed: https://crrev.com/99b895a54384834c5eb2544aec388c6d933bc167
Cr-Commit-Position: refs/heads/master@{#390184}

[sof, 2016-04-27 12:18:53]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org, thakis@chromium.org

[sof, 2016-04-27 12:18:54]

please take a look.

[haraken, 2016-04-27 12:33:52]

LGTM

[Nico, 2016-04-27 20:24:18]

rs-lgtm

[sof, 2016-04-27 21:01:44]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-04-27 21:02:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922913004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922913004/1

[commit-bot: I haz the power, 2016-04-27 21:07:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 17:13:06]

Patchset 1 (id:??) landed as
https://crrev.com/99b895a54384834c5eb2544aec388c6d933bc167
Cr-Commit-Position: refs/heads/master@{#390184}

[commit-bot: I haz the power, 2016-04-30 17:51:54]

Description was changed from

==========
Make warn-unneeded-finalizer warning usable.

The Blink GC plugin option warn-unneeded-finalizer (enabled by including
"warn-unneeded-finalizer=1" in your  "blink_gc_plugin_flags" gyp defines)
is potentially useful in identifying classes which needlessly derive from
GarbageCollectedFinalized<> where GarbageCollected<> would do.

To avoid far too many false positives to make it practically useful on
the Blink codebase, make it be more forgiving about bases with virtual
destructors + recognize class declarations with
finalizeGarbageCollectedObject() methods defined. Neither of those
two cases should be reported as warnings.

R=
BUG=
==========

to

==========
Make warn-unneeded-finalizer warning usable.

The Blink GC plugin option warn-unneeded-finalizer (enabled by including
"warn-unneeded-finalizer=1" in your  "blink_gc_plugin_flags" gyp defines)
is potentially useful in identifying classes which needlessly derive from
GarbageCollectedFinalized<> where GarbageCollected<> would do.

To avoid far too many false positives to make it practically useful on
the Blink codebase, make it be more forgiving about bases with virtual
destructors + recognize class declarations with
finalizeGarbageCollectedObject() methods defined. Neither of those
two cases should be reported as warnings.

R=
BUG=

Committed: https://crrev.com/99b895a54384834c5eb2544aec388c6d933bc167
Cr-Commit-Position: refs/heads/master@{#390184}
==========