tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.h - Issue 1922913004: Make warn-unneeded-finalizer warning usable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.h

Issue 1922913004: Make warn-unneeded-finalizer warning usable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp ('k') | tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.h

diff --git a/tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.h b/tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.h

index 000dfd74142ebbaf0915a8328c1a43dd207294c1..c6530f30a4880af039c0c6380a3190ec89bbbba1 100644

--- a/tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.h

+++ b/tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.h

@@ -33,8 +33,10 @@ public:

virtual ~HasEmptyDtor() { }

};

-class DoesNotNeedFinalizer3

- : public GarbageCollectedFinalized<DoesNotNeedFinalizer3>,

+// If there are any virtual destructors involved, give up.

+class DoesNeedFinalizer2

+ : public GarbageCollectedFinalized<DoesNeedFinalizer2>,

public HasEmptyDtor {

public:

void trace(Visitor*);