Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1652)

Issue 1922903002: Fix reporting of TouchToFirstScroll latency metrics (Closed)

Created:
4 years, 7 months ago by dtapuska
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix reporting of TouchToFirstScroll latency metrics The metrics reported during GestureScrollUpdate contained mouse wheel event gestures as well. This appeared as increased data to be reported and showed a regression. To fix this tag when a gesture scroll update is generated by a mouse wheel event; and avoid these when reporting them to the uma metrics. BUG=605147 Review URL: https://codereview.chromium.org/1911963005 Cr-Commit-Position: refs/heads/master@{#389271} (cherry picked from commit 2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9) Committed: https://chromium.googlesource.com/chromium/src/+/b4e6e8438b71f84bc75c731b17e3651c3f357271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -22 lines) Patch
M content/browser/renderer_host/input/input_router_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_perftest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/latency_info.h View 3 chunks +6 lines, -3 lines 0 comments Download
M ui/events/latency_info.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 7 months ago (2016-04-26 14:58:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b4e6e8438b71f84bc75c731b17e3651c3f357271.

Powered by Google App Engine
This is Rietveld 408576698