Fix reporting of TouchToFirstScroll latency metrics

Fix reporting of TouchToFirstScroll latency metrics

The metrics reported during GestureScrollUpdate contained mouse
wheel event gestures as well. This appeared as increased data
to be reported and showed a regression.

To fix this tag when a gesture scroll update is generated by a mouse
wheel event; and avoid these when reporting them to the uma metrics.

BUG=605147
Committed: https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9
Cr-Commit-Position: refs/heads/master@{#389271}

[dtapuska, 2016-04-22 17:04:48]

Description was changed from

==========
Fix reporting of TouchToFirstScroll latency metrics

The metrics reported during GestureScrollUpdate contained mouse
wheel event gestures as well. This appeared as increased data
to be reported and showed a regression.

To fix this tag when a gesture scroll update is generated by a mouse
wheel event; and avoid these when reporting them to the uma metrics.

BUG=605147
==========

to

==========
Fix reporting of TouchToFirstScroll latency metrics

The metrics reported during GestureScrollUpdate contained mouse
wheel event gestures as well. This appeared as increased data
to be reported and showed a regression.

To fix this tag when a gesture scroll update is generated by a mouse
wheel event; and avoid these when reporting them to the uma metrics.

BUG=605147
==========

[dtapuska, 2016-04-22 17:04:48]

dtapuska@chromium.org changed reviewers:
+ tdresser@chromium.org

[tdresser, 2016-04-22 17:55:59]

LGTM. We should merge this into M51.

https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/input_router_impl.cc (right):

https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/input_router_impl.cc:297: void
InputRouterImpl::ForwardGestureEvent(const blink::WebGestureEvent& event,
If we're renaming the client method, should we rename this too?

https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
(right):

https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/render_widget_host_latency_tracker.cc:431:
// reported on Touch metrics and we need to be consistent across reporting
nit: inconsistent capitalization.

Might as well "Touch" -> "touch"

https://codereview.chromium.org/1911963005/diff/1/ui/events/latency_info.h
File ui/events/latency_info.h (right):

https://codereview.chromium.org/1911963005/diff/1/ui/events/latency_info.h#ne...
ui/events/latency_info.h:70: // Timestamp of when the scroll update gesture from
a mouse wheel event.
Comment is missing a verb or two.

[dtapuska, 2016-04-22 18:15:00]

https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/input_router_impl.cc (right):

https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/input_router_impl.cc:297: void
InputRouterImpl::ForwardGestureEvent(const blink::WebGestureEvent& event,
On 2016/04/22 17:55:59, tdresser wrote:
> If we're renaming the client method, should we rename this too?

Done.

https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
(right):

https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/render_widget_host_latency_tracker.cc:431:
// reported on Touch metrics and we need to be consistent across reporting
On 2016/04/22 17:55:59, tdresser wrote:
> nit: inconsistent capitalization.
> 
> Might as well "Touch" -> "touch"

Done.

https://codereview.chromium.org/1911963005/diff/1/ui/events/latency_info.h
File ui/events/latency_info.h (right):

https://codereview.chromium.org/1911963005/diff/1/ui/events/latency_info.h#ne...
ui/events/latency_info.h:70: // Timestamp of when the scroll update gesture from
a mouse wheel event.
On 2016/04/22 17:55:59, tdresser wrote:
> Comment is missing a verb or two.

Done.

[dtapuska, 2016-04-22 19:28:36]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-04-22 19:28:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1911963005/#ps20001
(title: "Fix a few nits")

[commit-bot: I haz the power, 2016-04-22 19:29:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911963005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911963005/20001

[commit-bot: I haz the power, 2016-04-22 22:27:39]

Description was changed from

==========
Fix reporting of TouchToFirstScroll latency metrics

The metrics reported during GestureScrollUpdate contained mouse
wheel event gestures as well. This appeared as increased data
to be reported and showed a regression.

To fix this tag when a gesture scroll update is generated by a mouse
wheel event; and avoid these when reporting them to the uma metrics.

BUG=605147
==========

to

==========
Fix reporting of TouchToFirstScroll latency metrics

The metrics reported during GestureScrollUpdate contained mouse
wheel event gestures as well. This appeared as increased data
to be reported and showed a regression.

To fix this tag when a gesture scroll update is generated by a mouse
wheel event; and avoid these when reporting them to the uma metrics.

BUG=605147
==========

[commit-bot: I haz the power, 2016-04-22 22:27:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 22:29:55]

Description was changed from

==========
Fix reporting of TouchToFirstScroll latency metrics

The metrics reported during GestureScrollUpdate contained mouse
wheel event gestures as well. This appeared as increased data
to be reported and showed a regression.

To fix this tag when a gesture scroll update is generated by a mouse
wheel event; and avoid these when reporting them to the uma metrics.

BUG=605147
==========

to

==========
Fix reporting of TouchToFirstScroll latency metrics

The metrics reported during GestureScrollUpdate contained mouse
wheel event gestures as well. This appeared as increased data
to be reported and showed a regression.

To fix this tag when a gesture scroll update is generated by a mouse
wheel event; and avoid these when reporting them to the uma metrics.

BUG=605147

Committed: https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9
Cr-Commit-Position: refs/heads/master@{#389271}
==========

[commit-bot: I haz the power, 2016-04-22 22:29:56]

Patchset 2 (id:??) landed as
https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9
Cr-Commit-Position: refs/heads/master@{#389271}