Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1911963005: Fix reporting of TouchToFirstScroll latency metrics (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix reporting of TouchToFirstScroll latency metrics The metrics reported during GestureScrollUpdate contained mouse wheel event gestures as well. This appeared as increased data to be reported and showed a regression. To fix this tag when a gesture scroll update is generated by a mouse wheel event; and avoid these when reporting them to the uma metrics. BUG=605147 Committed: https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9 Cr-Commit-Position: refs/heads/master@{#389271}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix a few nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -22 lines) Patch
M content/browser/renderer_host/input/input_router_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_perftest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/latency_info.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M ui/events/latency_info.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dtapuska
4 years, 8 months ago (2016-04-22 17:09:29 UTC) #3
tdresser
LGTM. We should merge this into M51. https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_host/input/input_router_impl.cc File content/browser/renderer_host/input/input_router_impl.cc (right): https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_host/input/input_router_impl.cc#newcode297 content/browser/renderer_host/input/input_router_impl.cc:297: void InputRouterImpl::ForwardGestureEvent(const ...
4 years, 8 months ago (2016-04-22 17:55:59 UTC) #4
dtapuska
https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_host/input/input_router_impl.cc File content/browser/renderer_host/input/input_router_impl.cc (right): https://codereview.chromium.org/1911963005/diff/1/content/browser/renderer_host/input/input_router_impl.cc#newcode297 content/browser/renderer_host/input/input_router_impl.cc:297: void InputRouterImpl::ForwardGestureEvent(const blink::WebGestureEvent& event, On 2016/04/22 17:55:59, tdresser wrote: ...
4 years, 8 months ago (2016-04-22 18:15:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911963005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911963005/20001
4 years, 8 months ago (2016-04-22 19:29:08 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 22:27:40 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 22:29:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9
Cr-Commit-Position: refs/heads/master@{#389271}

Powered by Google App Engine
This is Rietveld 408576698