Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 192283002: Revert 255858 "Simplify the user agent code some more since afte..." (Closed)

Created:
6 years, 9 months ago by jam
Modified:
6 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 255858 "Simplify the user agent code some more since afte..." There are some browser_tests failures on the buildbots that don't reproduce locally. Reverting while I investigate. > Simplify the user agent code some more since after r255534 it's not affected by the site's URL. > > Code in content always gets it now from ContentClient::GetUserAgent. In Chrome, there's a GetUserAgent function which returns it. > > BUG=338338 > R=isherman@chromium.org, pauljensen@chromium.org, scottmg@chromium.org, tfarina@chromium.org > > Review URL: https://codereview.chromium.org/191093002 TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -129 lines) Patch
M trunk/src/android_webview/browser/net/aw_url_request_context_getter.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/android_webview/common/aw_content_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/android_webview/common/aw_content_client.cc View 2 chunks +3 lines, -15 lines 0 comments Download
M trunk/src/android_webview/native/aw_settings.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/autofill/risk/fingerprint_browsertest.cc View 3 chunks +1 line, -3 lines 0 comments Download
M trunk/src/chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/auto_enrollment_client.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/device_local_account_policy_service.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/feedback/feedback_util.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/invalidation/ticl_invalidation_service.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/io_thread.cc View 4 chunks +2 lines, -3 lines 0 comments Download
A + trunk/src/chrome/browser/net/basic_http_user_agent_settings.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/net/basic_http_user_agent_settings.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/net/chrome_http_user_agent_settings.h View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/net/chrome_http_user_agent_settings.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/net/preconnect.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/policy/cloud/user_policy_signin_service_base.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/profile_resetter/resettable_settings_snapshot.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/task_profiler/task_profiler_data_serializer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/help/help_handler.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/version_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/chrome_content_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/common/chrome_content_client.cc View 2 chunks +10 lines, -21 lines 0 comments Download
M trunk/src/chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/components/autofill/content/browser/risk/fingerprint.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/components/autofill/content/browser/risk/fingerprint.cc View 9 chunks +6 lines, -12 lines 0 comments Download
M trunk/src/content/app/content_main_runner.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M trunk/src/content/browser/devtools/devtools_http_handler_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/content/browser/media/android/browser_media_player_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/plugin_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/child/blink_platform_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/child/blink_platform_impl.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/content/child/npapi/plugin_host.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/public/common/content_client.h View 1 chunk +10 lines, -0 lines 0 comments Download
M trunk/src/content/public/common/content_client.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M trunk/src/content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_url_request_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/service_worker/embedded_worker_dispatcher.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/content/test/test_webkit_platform_support.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/test/test_webkit_platform_support.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M trunk/src/content/test/webkit_support.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/http_user_agent_settings.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/net/url_request/static_http_user_agent_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/url_request/static_http_user_agent_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/url_request/url_request_http_job.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + trunk/src/webkit/common/user_agent/user_agent.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/webkit/common/user_agent/user_agent.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/webkit/common/user_agent/webkit_user_agent.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jam
6 years, 9 months ago (2014-03-09 20:08:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698