Do not download Linux sysroots.

Do not download Linux sysroots.

Committed: https://pdfium.googlesource.com/pdfium/+/543651f9d8d8cb9ec45dce5fe3d06c2e6013de7d

[Lei Zhang, 2016-04-25 23:38:56]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Lei Zhang, 2016-04-25 23:38:57]

This got pulled in with https://codereview.chromium.org/1904563002, but I don't
think we are using sysroots at all in the standalone build.

[dsinclair, 2016-04-25 23:59:47]

Does the standalone GN build work for you without this? I need to have the
sysroot as there is stuff in //build which seemed to require it when building
with GN.

[Lei Zhang, 2016-04-26 00:05:15]

Nope. git grep doesn't search build/ so I missed a bunch of things. Let me go
back to the drawing board.

[dsinclair, 2016-04-26 00:07:05]

On 2016/04/26 00:05:15, Lei Zhang wrote:
> Nope. git grep doesn't search build/ so I missed a bunch of things. Let me go
> back to the drawing board.

Is it causing issues to have the sysroot.

[Lei Zhang, 2016-04-26 00:12:24]

On 2016/04/26 00:07:05, dsinclair wrote:
> On 2016/04/26 00:05:15, Lei Zhang wrote:
> > Nope. git grep doesn't search build/ so I missed a bunch of things. Let me
go
> > back to the drawing board.
> 
> Is it causing issues to have the sysroot.

Well, it causes this extra download that uses 270 MB of disk space, and the gyp
build does not use the sysroot.

[Lei Zhang, 2016-04-26 00:12:25]

On 2016/04/26 00:07:05, dsinclair wrote:
> On 2016/04/26 00:05:15, Lei Zhang wrote:
> > Nope. git grep doesn't search build/ so I missed a bunch of things. Let me
go
> > back to the drawing board.
> 
> Is it causing issues to have the sysroot.

Well, it causes this extra download that uses 270 MB of disk space, and the gyp
build does not use the sysroot.

[dsinclair, 2016-04-26 16:51:57]

On 2016/04/26 00:12:25, Lei Zhang wrote:
> On 2016/04/26 00:07:05, dsinclair wrote:
> > On 2016/04/26 00:05:15, Lei Zhang wrote:
> > > Nope. git grep doesn't search build/ so I missed a bunch of things. Let me
> go
> > > back to the drawing board.
> > 
> > Is it causing issues to have the sysroot.
> 
> Well, it causes this extra download that uses 270 MB of disk space, and the
gyp
> build does not use the sysroot.


Maybe ping the GN folks to see if the sysroot is going to be required moving
forward with GN?

[Lei Zhang, 2016-05-13 22:11:27]

On 2016/04/26 00:05:15, Lei Zhang wrote:
> Nope. git grep doesn't search build/ so I missed a bunch of things. Let me go
> back to the drawing board.

I tried again last night with ToT, and it works if I set use_sysroot = false. I
still need to talk to the GN folks, because their build/ rules for Chromium
doesn't always make sense for other projects.

[dsinclair, 2016-05-16 13:45:51]

On 2016/05/13 22:11:27, Lei Zhang wrote:
> On 2016/04/26 00:05:15, Lei Zhang wrote:
> > Nope. git grep doesn't search build/ so I missed a bunch of things. Let me
go
> > back to the drawing board.
> 
> I tried again last night with ToT, and it works if I set use_sysroot = false.
I
> still need to talk to the GN folks, because their build/ rules for Chromium
> doesn't always make sense for other projects.

Can you update the README to add use_sysroot = false in the 'Selecting build
configuration' example?

[Lei Zhang, 2016-05-17 00:36:42]

On 2016/05/16 13:45:51, dsinclair wrote:
> Can you update the README to add use_sysroot = false in the 'Selecting build
> configuration' example?

Done.

[dsinclair, 2016-05-17 02:12:31]

lgtm

[Lei Zhang, 2016-05-17 02:19:12]

Oh, still doesn't work on GN bots by default.

[dsinclair, 2016-05-17 20:22:37]

On 2016/05/17 02:19:12, Lei Zhang wrote:
> Oh, still doesn't work on GN bots by default.


I'm guessing you'll need to change the use_sysroot into something that can be
added to the build_overrides. Maybe something like
https://codereview.chromium.org/1901313002/?

[dsinclair, 2016-08-17 18:31:36]

dsinclair@chromium.org changed reviewers:
- dsinclair@chromium.org

[Lei Zhang, 2016-08-31 20:47:06]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 20:47:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-31 20:47:30]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Lei Zhang, 2016-08-31 20:47:31]

I think we just need to reconfigure the bots?
https://codereview.chromium.org/2295383002

[commit-bot: I haz the power, 2016-08-31 20:49:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 20:49:24]

Dry run: Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/586)

[Lei Zhang, 2016-08-31 23:02:50]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 23:02:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 23:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 23:38:55]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-31 23:40:36]

Now that the bots are green, shall we land this?

[dsinclair, 2016-09-01 14:11:28]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-01 14:11:28]

lgtm

[commit-bot: I haz the power, 2016-09-01 14:11:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-09-01 14:11:46]

The CQ bit was unchecked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-09-01 14:11:48]

Description was changed from

==========
Do not download Linux sysroots.
==========

to

==========
Do not download Linux sysroots.

Committed:
https://pdfium.googlesource.com/pdfium/+/543651f9d8d8cb9ec45dce5fe3d06c2e6013...
==========

[commit-bot: I haz the power, 2016-09-01 14:11:49]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/543651f9d8d8cb9ec45dce5fe3d06c2e6013...

[dsinclair, 2016-09-01 14:12:15]

Actually, looks like the linux_skia bot has gn errors around the sysroot. Can
you fix that up before landing?

[dsinclair, 2016-09-01 14:13:17]

On 2016/09/01 14:12:15, dsinclair wrote:
> Actually, looks like the linux_skia bot has gn errors around the sysroot. Can
> you fix that up before landing?

Do, wasn't fast enough unchecking the box. Can you fix:
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_skia/buil...

[Lei Zhang, 2016-09-01 17:06:49]

On 2016/09/01 14:13:17, dsinclair wrote:
> On 2016/09/01 14:12:15, dsinclair wrote:
> > Actually, looks like the linux_skia bot has gn errors around the sysroot.
Can
> > you fix that up before landing?
> 
> Do, wasn't fast enough unchecking the box. Can you fix:
>
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_skia/buil...

I think that bot was on the old config. I'll keep an eye on
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_skia/ and
make sure new builds are ok.