Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2295383002: Add use_sysroot=false to Linux PDFium bots. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, dsinclair
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : syntax fail #

Patch Set 3 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M scripts/slave/recipes/pdfium.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/android.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_asan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_no_v8.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_skia.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_asan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (19 generated)
Lei Zhang
Precursor to landing https://codereview.chromium.org/1922773002/
4 years, 3 months ago (2016-08-31 20:48:25 UTC) #4
dsinclair
lgtm w/ syntax fix. https://codereview.chromium.org/2295383002/diff/1/scripts/slave/recipes/pdfium.py File scripts/slave/recipes/pdfium.py (right): https://codereview.chromium.org/2295383002/diff/1/scripts/slave/recipes/pdfium.py#newcode58 scripts/slave/recipes/pdfium.py:58: if api.platform.is_linux Missing :
4 years, 3 months ago (2016-08-31 20:51:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295383002/40001
4 years, 3 months ago (2016-08-31 21:52:01 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30fb680df9598910)
4 years, 3 months ago (2016-08-31 22:02:41 UTC) #21
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-31 22:03:53 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295383002/40001
4 years, 3 months ago (2016-08-31 22:48:08 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:52:31 UTC) #26
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/6c9d33b2cad5e6ac8871...

Powered by Google App Engine
This is Rietveld 408576698