Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1922763003: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, shans, eae+blinkwatch, fs, dcheng, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, krit, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, gyuyoung2, rwlbuis, Eric Willigers, rjwright, Mads Ager (chromium), sof, darktears, dtapuska+blinkwatch_chromium.org, blink-reviews-animation_chromium.org, f(malita), oilpan-reviews, Stephen Chennney, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary uses of GarbageCollectedFinalized<>. R=haraken BUG=585328 Committed: https://crrev.com/171fc5b5c4c1049453db1ce079e85750d2727a08 Cr-Commit-Position: refs/heads/master@{#389756}

Patch Set 1 #

Total comments: 1

Patch Set 2 : undo revival of unused includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -38 lines) Patch
M third_party/WebKit/Source/core/dom/MessageChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/InputDeviceCapabilities.h View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/InputDeviceCapabilities.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragState.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableByteStreamReader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceObserver.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceObserver.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/xml/DOMParser.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathNodeSet.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathResult.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
sof
please take a look.
4 years, 7 months ago (2016-04-26 09:55:07 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-04-26 11:01:13 UTC) #3
sof
https://codereview.chromium.org/1922763003/diff/1/third_party/WebKit/Source/core/timing/PerformanceObserver.h File third_party/WebKit/Source/core/timing/PerformanceObserver.h (right): https://codereview.chromium.org/1922763003/diff/1/third_party/WebKit/Source/core/timing/PerformanceObserver.h#newcode11 third_party/WebKit/Source/core/timing/PerformanceObserver.h:11: #include "wtf/HashSet.h" oops, these unused ones were mistakenly re-added ...
4 years, 7 months ago (2016-04-26 11:07:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922763003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922763003/20001
4 years, 7 months ago (2016-04-26 11:08:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-26 12:41:08 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 12:42:18 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/171fc5b5c4c1049453db1ce079e85750d2727a08
Cr-Commit-Position: refs/heads/master@{#389756}

Powered by Google App Engine
This is Rietveld 408576698