third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp - Issue 1922763003: Remove unnecessary uses of GarbageCollectedFinalized<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp

Issue 1922763003: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: undo revival of unused includes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/streams/ReadableByteStreamReader.h ('k') | third_party/WebKit/Source/core/timing/PerformanceObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp b/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp

index 92f1e1944e4cb7f0a04ad950ac571def4447b15c..9030a03e86711a6b5b03d48aede82491a1046654 100644

--- a/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp

@@ -158,8 +158,7 @@ void SVGAnimatedTypeAnimator::calculateFromAndByValues(Member<SVGPropertyBase>&

{

from = constructFromString(fromString);

to = constructFromString(byString);

- // FIXME(oilpan): Below .get() should be removed after transition types are gone.

- to->add(from.get(), m_contextElement);

+ to->add(from, m_contextElement);

}

namespace {