Send TestFinished as Process/Control-msg (not View-msg).

Handle layout tests that finish in OOPIFs.

When a layout test finishes, it calls BlinkTestRunner's TestFinished
method.  If the main test frame resides in another renderer process,
then BlinkTestRunner sends a message to the browser process to let it
know that the test has finished (and to let it forward this notification
to the main test frame).

Before this CL, when a layout test would finish in an OOPIF, then
RenderView associated with BlinkTestRunner would be swapped-out, and
this meant that the notification message would be dropped and the test
would time out.  After this CL, the notification message is sent
as a process/control message - this means that it reaches the browser
regardless of the swapped-out state of RenderViews.  This fixes 25+
timeouts in --site-per-process mode.

This CL depends on many earlier CLs that had to ensure that tests finish
at the right moment - this requires proper tracking of top loading frame
across all renderers (https://crrev.com/1908233002), as well as properly
identifying the main test window (https://crrev.com/1896623002).

This CL also highlights that the main frame receives notification that
the test has finished in another renderer, *not* that another renderer
called testRunner.notifyDone (i.e. BlinkTestRunner::TestFinished can
also be called when test finishes due to the top loading frame finishing
loading).  This means that the main frame doesn't execute
testRunner.notifyDone itself, but directly calls
BlinkTestRunner::TestFinished (calling notifyDone would not have worked
due to earlier resetting of wait_until_done LayoutTestRuntimeFlag).

Finally this CL, tweaks redirect-methods.html test to ensure that it
consistently allows WebFrameClient callbacks to be called (without
--site-per-process the delay would have occured because
top-loading-frame would still be tracked and would have prevented
synchronous finishing of the test when testRunner.notifyDone is called).

BUG=595895
Committed: https://crrev.com/042327073131b53a3a3f7d06c7e56d8eadaed9d2
Cr-Commit-Position: refs/heads/master@{#390398}

[Łukasz Anforowicz, 2016-04-26 16:39:27]

Description was changed from

==========
Send TestFinished as Process/Control-msg (not View-msg).

This ensures that the message can reach the browser in case
of a swapped-out RenderView (i.e. when test finishes in an OOPIF).
This fixes a few timeouts that were happening in --site-per-process mode.

BUG=595895
==========

to

==========
Handle layout tests that finish in OOPIFs.

When a layout test finishes, it calls BlinkTestRunner's TestFinished
method.  If the main test frame resides in another renderer process,
then BlinkTestRunner sends a message to the browser process to let it
know that the test has finished (and to let it forward this notification
to the main test frame).

Before this CL, when a layout test would finish in an OOPIF, then
RenderView associated with BlinkTestRunner would be swapped-out, and
this meant that the notification message would be dropped and the test
would time out.  After this CL, the notification message is sent
as a process/control message - this means that it reaches the browser
regardless of the swapped-out state of RenderViews.  This fixes 25+
timeouts in --site-per-process mode.

This CL depends on many earlier CLs that had to ensure that tests finish
at the right moment - this requires proper tracking of top loading frame
across all renderers (https://crrev.com/1908233002), as well as properly
identifying the main test window (https://crrev.com/1896623002).

This CL also highlights that the main frame receives notification that
the test has finished in another renderer, *not* that another renderer
called testRunner.notifyDone (i.e. BlinkTestRunner::TestFinished can
also be called when test finishes due to the top loading frame finishing
loading).  This means that the main frame doesn't execute
testRunner.notifyDone itself, but directly calls
BlinkTestRunner::TestFinished (calling notifyDone would not have worked
due to earlier resetting of wait_until_done LayoutTestRuntimeFlag).

Finally this CL, tweaks redirect-methods.html test to ensure that it
consistently allows WebFrameClient callbacks to be called (without
--site-per-process the delay would have occured because
top-loading-frame would still be tracked and would have prevented
synchronous finishing of the test when testRunner.notifyDone is called).

BUG=595895
==========

[Łukasz Anforowicz, 2016-04-26 16:40:21]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-04-26 16:40:22]

jochen@, could you please take a look?

[jochen (gone - plz use gerrit), 2016-04-27 12:05:24]

lgtm

[Łukasz Anforowicz, 2016-04-28 14:40:56]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 14:41:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922653003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922653003/40001

[commit-bot: I haz the power, 2016-04-28 15:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 15:42:16]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-04-28 15:56:51]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-04-28 15:56:51]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1922653003/#ps40001
(title: "Rebasing...")

[commit-bot: I haz the power, 2016-04-28 15:57:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922653003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922653003/40001

[commit-bot: I haz the power, 2016-04-28 16:02:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 16:02:20]

Failed to apply the patch.

[commit-bot: I haz the power, 2016-04-28 16:02:21]

The CQ bit was unchecked by commit-bot@chromium.org

[Łukasz Anforowicz, 2016-04-28 16:19:53]

On 2016/04/28 16:02:20, commit-bot: I haz the power wrote:
> Failed to apply the patch.

Weird... despite the message about the patch did end up at ToT:

Cr-Commit-Position: refs/heads/master@{#390398}
https://chromium.googlesource.com/chromium/src.git/+/042327073131b53a3a3f7d06...

[Łukasz Anforowicz, 2016-04-28 16:20:28]

Description was changed from

==========
Handle layout tests that finish in OOPIFs.

When a layout test finishes, it calls BlinkTestRunner's TestFinished
method.  If the main test frame resides in another renderer process,
then BlinkTestRunner sends a message to the browser process to let it
know that the test has finished (and to let it forward this notification
to the main test frame).

Before this CL, when a layout test would finish in an OOPIF, then
RenderView associated with BlinkTestRunner would be swapped-out, and
this meant that the notification message would be dropped and the test
would time out.  After this CL, the notification message is sent
as a process/control message - this means that it reaches the browser
regardless of the swapped-out state of RenderViews.  This fixes 25+
timeouts in --site-per-process mode.

This CL depends on many earlier CLs that had to ensure that tests finish
at the right moment - this requires proper tracking of top loading frame
across all renderers (https://crrev.com/1908233002), as well as properly
identifying the main test window (https://crrev.com/1896623002).

This CL also highlights that the main frame receives notification that
the test has finished in another renderer, *not* that another renderer
called testRunner.notifyDone (i.e. BlinkTestRunner::TestFinished can
also be called when test finishes due to the top loading frame finishing
loading).  This means that the main frame doesn't execute
testRunner.notifyDone itself, but directly calls
BlinkTestRunner::TestFinished (calling notifyDone would not have worked
due to earlier resetting of wait_until_done LayoutTestRuntimeFlag).

Finally this CL, tweaks redirect-methods.html test to ensure that it
consistently allows WebFrameClient callbacks to be called (without
--site-per-process the delay would have occured because
top-loading-frame would still be tracked and would have prevented
synchronous finishing of the test when testRunner.notifyDone is called).

BUG=595895
==========

to

==========
Handle layout tests that finish in OOPIFs.

When a layout test finishes, it calls BlinkTestRunner's TestFinished
method.  If the main test frame resides in another renderer process,
then BlinkTestRunner sends a message to the browser process to let it
know that the test has finished (and to let it forward this notification
to the main test frame).

Before this CL, when a layout test would finish in an OOPIF, then
RenderView associated with BlinkTestRunner would be swapped-out, and
this meant that the notification message would be dropped and the test
would time out.  After this CL, the notification message is sent
as a process/control message - this means that it reaches the browser
regardless of the swapped-out state of RenderViews.  This fixes 25+
timeouts in --site-per-process mode.

This CL depends on many earlier CLs that had to ensure that tests finish
at the right moment - this requires proper tracking of top loading frame
across all renderers (https://crrev.com/1908233002), as well as properly
identifying the main test window (https://crrev.com/1896623002).

This CL also highlights that the main frame receives notification that
the test has finished in another renderer, *not* that another renderer
called testRunner.notifyDone (i.e. BlinkTestRunner::TestFinished can
also be called when test finishes due to the top loading frame finishing
loading).  This means that the main frame doesn't execute
testRunner.notifyDone itself, but directly calls
BlinkTestRunner::TestFinished (calling notifyDone would not have worked
due to earlier resetting of wait_until_done LayoutTestRuntimeFlag).

Finally this CL, tweaks redirect-methods.html test to ensure that it
consistently allows WebFrameClient callbacks to be called (without
--site-per-process the delay would have occured because
top-loading-frame would still be tracked and would have prevented
synchronous finishing of the test when testRunner.notifyDone is called).

BUG=595895
==========

[commit-bot: I haz the power, 2016-04-30 17:19:01]

Patchset 3 (id:??) landed as
https://crrev.com/042327073131b53a3a3f7d06c7e56d8eadaed9d2
Cr-Commit-Position: refs/heads/master@{#390398}

[commit-bot: I haz the power, 2016-04-30 17:56:08]

Description was changed from

==========
Handle layout tests that finish in OOPIFs.

When a layout test finishes, it calls BlinkTestRunner's TestFinished
method.  If the main test frame resides in another renderer process,
then BlinkTestRunner sends a message to the browser process to let it
know that the test has finished (and to let it forward this notification
to the main test frame).

Before this CL, when a layout test would finish in an OOPIF, then
RenderView associated with BlinkTestRunner would be swapped-out, and
this meant that the notification message would be dropped and the test
would time out.  After this CL, the notification message is sent
as a process/control message - this means that it reaches the browser
regardless of the swapped-out state of RenderViews.  This fixes 25+
timeouts in --site-per-process mode.

This CL depends on many earlier CLs that had to ensure that tests finish
at the right moment - this requires proper tracking of top loading frame
across all renderers (https://crrev.com/1908233002), as well as properly
identifying the main test window (https://crrev.com/1896623002).

This CL also highlights that the main frame receives notification that
the test has finished in another renderer, *not* that another renderer
called testRunner.notifyDone (i.e. BlinkTestRunner::TestFinished can
also be called when test finishes due to the top loading frame finishing
loading).  This means that the main frame doesn't execute
testRunner.notifyDone itself, but directly calls
BlinkTestRunner::TestFinished (calling notifyDone would not have worked
due to earlier resetting of wait_until_done LayoutTestRuntimeFlag).

Finally this CL, tweaks redirect-methods.html test to ensure that it
consistently allows WebFrameClient callbacks to be called (without
--site-per-process the delay would have occured because
top-loading-frame would still be tracked and would have prevented
synchronous finishing of the test when testRunner.notifyDone is called).

BUG=595895
==========

to

==========
Handle layout tests that finish in OOPIFs.

When a layout test finishes, it calls BlinkTestRunner's TestFinished
method.  If the main test frame resides in another renderer process,
then BlinkTestRunner sends a message to the browser process to let it
know that the test has finished (and to let it forward this notification
to the main test frame).

Before this CL, when a layout test would finish in an OOPIF, then
RenderView associated with BlinkTestRunner would be swapped-out, and
this meant that the notification message would be dropped and the test
would time out.  After this CL, the notification message is sent
as a process/control message - this means that it reaches the browser
regardless of the swapped-out state of RenderViews.  This fixes 25+
timeouts in --site-per-process mode.

This CL depends on many earlier CLs that had to ensure that tests finish
at the right moment - this requires proper tracking of top loading frame
across all renderers (https://crrev.com/1908233002), as well as properly
identifying the main test window (https://crrev.com/1896623002).

This CL also highlights that the main frame receives notification that
the test has finished in another renderer, *not* that another renderer
called testRunner.notifyDone (i.e. BlinkTestRunner::TestFinished can
also be called when test finishes due to the top loading frame finishing
loading).  This means that the main frame doesn't execute
testRunner.notifyDone itself, but directly calls
BlinkTestRunner::TestFinished (calling notifyDone would not have worked
due to earlier resetting of wait_until_done LayoutTestRuntimeFlag).

Finally this CL, tweaks redirect-methods.html test to ensure that it
consistently allows WebFrameClient callbacks to be called (without
--site-per-process the delay would have occured because
top-loading-frame would still be tracked and would have prevented
synchronous finishing of the test when testRunner.notifyDone is called).

BUG=595895

Committed: https://crrev.com/042327073131b53a3a3f7d06c7e56d8eadaed9d2
Cr-Commit-Position: refs/heads/master@{#390398}
==========