Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/loading/redirect-methods.html

Issue 1922653003: Send TestFinished as Process/Control-msg (not View-msg). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@only-one-top-loading-frame-in-all-renderers
Patch Set: Rebasing... Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/site-per-process ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/loading/redirect-methods.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/redirect-methods.html b/third_party/WebKit/LayoutTests/http/tests/loading/redirect-methods.html
index 55e2cdbbc939b76a0397e3f8817143f2246a3d08..39abd27fad51a52d246bf5e6dd51b07804fb8bcf 100644
--- a/third_party/WebKit/LayoutTests/http/tests/loading/redirect-methods.html
+++ b/third_party/WebKit/LayoutTests/http/tests/loading/redirect-methods.html
@@ -33,8 +33,14 @@ function iframeLoaded(frameID)
var iframe = document.getElementById(frameID);
if (iframe.hasAttribute("submitted")) {
if (++frameID == testCodes.length) {
- if (window.testRunner)
- testRunner.notifyDone();
+ if (window.testRunner) {
+ // Before finishing the test, we have to allow the callstack to
+ // unwind - this enables dumping of pending WebFrameClient
+ // callbacks (i.e. didFinishLoad and/or didHandleOnloadEvents).
+ window.setTimeout(function() {
+ testRunner.notifyDone();
+ }, 0);
+ }
return;
}
createFrame(frameID);
« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/site-per-process ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698