Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1765)

Unified Diff: components/crash/content/app/breakpad_win.cc

Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Greg's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/components_tests.gyp ('k') | components/crash/content/app/crash_reporter_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/breakpad_win.cc
diff --git a/components/crash/content/app/breakpad_win.cc b/components/crash/content/app/breakpad_win.cc
index 9f158ff674f169be0aea2da126e4d001cff3b0a1..01b32bd3f34d2e8aa6661f9843dbd5ce93261943 100644
--- a/components/crash/content/app/breakpad_win.cc
+++ b/components/crash/content/app/breakpad_win.cc
@@ -199,8 +199,6 @@ namespace {
bool DumpDoneCallbackWhenNoCrash(const wchar_t*, const wchar_t*, void*,
EXCEPTION_POINTERS* ex_info,
MDRawAssertionInfo*, bool succeeded) {
- GetCrashReporterClient()->RecordCrashDumpAttemptResult(
- false /* is_real_crash */, succeeded);
return true;
}
@@ -213,8 +211,6 @@ bool DumpDoneCallbackWhenNoCrash(const wchar_t*, const wchar_t*, void*,
bool DumpDoneCallback(const wchar_t*, const wchar_t*, void*,
EXCEPTION_POINTERS* ex_info,
MDRawAssertionInfo*, bool succeeded) {
- GetCrashReporterClient()->RecordCrashDumpAttemptResult(
- true /* is_real_crash */, succeeded);
// Check if the exception is one of the kind which would not be solved
// by simply restarting chrome. In this case we show a message box with
// and exit silently. Remember that chrome is in a crashed state so we
@@ -246,7 +242,6 @@ volatile LONG handling_exception = 0;
// to implement it.
bool FilterCallbackWhenNoCrash(
void*, EXCEPTION_POINTERS*, MDRawAssertionInfo*) {
- GetCrashReporterClient()->RecordCrashDumpAttempt(false);
return true;
}
@@ -260,7 +255,6 @@ bool FilterCallback(void*, EXCEPTION_POINTERS*, MDRawAssertionInfo*) {
if (::InterlockedCompareExchange(&handling_exception, 1, 0) == 1) {
::Sleep(INFINITE);
}
- GetCrashReporterClient()->RecordCrashDumpAttempt(true);
return true;
}
@@ -581,9 +575,6 @@ void InitCrashReporter(const std::string& process_type_switch) {
if (GetCrashReporterClient()->ShouldCreatePipeName(process_type))
InitPipeNameEnvVar(is_per_user_install);
- if (process_type == L"browser")
- GetCrashReporterClient()->InitBrowserCrashDumpsRegKey();
-
std::unique_ptr<base::Environment> env(base::Environment::Create());
std::string pipe_name_ascii;
if (!env->GetVar(kPipeNameVar, &pipe_name_ascii)) {
« no previous file with comments | « components/components_tests.gyp ('k') | components/crash/content/app/crash_reporter_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698