Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3838)

Unified Diff: chrome/browser/metrics/chrome_stability_metrics_provider.cc

Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Greg's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | chrome/common/metrics_constants_util_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/chrome_stability_metrics_provider.cc
diff --git a/chrome/browser/metrics/chrome_stability_metrics_provider.cc b/chrome/browser/metrics/chrome_stability_metrics_provider.cc
index 3c94a839446ecafa39539555a76bf509cd6d71f4..0742257d1b88aaba350d1e8a21988028e7c157a0 100644
--- a/chrome/browser/metrics/chrome_stability_metrics_provider.cc
+++ b/chrome/browser/metrics/chrome_stability_metrics_provider.cc
@@ -26,54 +26,8 @@
#if defined(OS_WIN)
#include <windows.h> // Needed for STATUS_* codes
#include "chrome/common/metrics_constants_util_win.h"
-#include "components/browser_watcher/crash_reporting_metrics_win.h"
#endif
-namespace {
-
-#if defined(OS_WIN)
-void CountBrowserCrashDumpAttempts() {
- enum Outcome {
- OUTCOME_SUCCESS,
- OUTCOME_FAILURE,
- OUTCOME_UNKNOWN,
- OUTCOME_MAX_VALUE
- };
-
- browser_watcher::CrashReportingMetrics::Values metrics =
- browser_watcher::CrashReportingMetrics(
- chrome::GetBrowserCrashDumpAttemptsRegistryPath())
- .RetrieveAndResetMetrics();
-
- for (int i = 0; i < metrics.crash_dump_attempts; ++i) {
- Outcome outcome = OUTCOME_UNKNOWN;
- if (i < metrics.successful_crash_dumps)
- outcome = OUTCOME_SUCCESS;
- else if (i < metrics.successful_crash_dumps + metrics.failed_crash_dumps)
- outcome = OUTCOME_FAILURE;
-
- UMA_STABILITY_HISTOGRAM_ENUMERATION("CrashReport.BreakpadCrashDumpOutcome",
- outcome, OUTCOME_MAX_VALUE);
- }
-
- for (int i = 0; i < metrics.dump_without_crash_attempts; ++i) {
- Outcome outcome = OUTCOME_UNKNOWN;
- if (i < metrics.successful_dumps_without_crash) {
- outcome = OUTCOME_SUCCESS;
- } else if (i < metrics.successful_dumps_without_crash +
- metrics.failed_dumps_without_crash) {
- outcome = OUTCOME_FAILURE;
- }
-
- UMA_STABILITY_HISTOGRAM_ENUMERATION(
- "CrashReport.BreakpadDumpWithoutCrashOutcome", outcome,
- OUTCOME_MAX_VALUE);
- }
-}
-#endif // defined(OS_WIN)
-
-} // namespace
-
ChromeStabilityMetricsProvider::ChromeStabilityMetricsProvider(
PrefService* local_state)
: helper_(local_state) {
@@ -103,10 +57,6 @@ void ChromeStabilityMetricsProvider::OnRecordingDisabled() {
void ChromeStabilityMetricsProvider::ProvideStabilityMetrics(
metrics::SystemProfileProto* system_profile_proto) {
helper_.ProvideStabilityMetrics(system_profile_proto);
-
-#if defined(OS_WIN)
- CountBrowserCrashDumpAttempts();
-#endif // defined(OS_WIN)
}
void ChromeStabilityMetricsProvider::ClearSavedStabilityMetrics() {
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | chrome/common/metrics_constants_util_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698