Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 19220002: [WIP] BufferedInputRouter (Closed)

Created:
7 years, 5 months ago by jdduke (slow)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org, kouhei (in TOK), varunjain
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[WIP] BufferedInputRouter This is meant as a tracking patch for all pending patches/changes that implement the BufferedInputRouter. This is not meant to be reviewed directly; constituent patches will be submitted invididually. The BufferedInputRouter batches input events into EventPackets. The delivery of these packets is synchronized with BeginFrame; a call to BeginFrame will flush the pending EventPacket, and the BeginFrame will be forwarded only after the packet response has been received. BUG=245499

Patch Set 1 #

Patch Set 2 : Merge fix #

Patch Set 3 : Fix unit tests #

Patch Set 4 : Copy paste fix... #

Patch Set 5 : Rebase and packet dropping logic #

Patch Set 6 : Rebase and refactor #

Patch Set 7 : Latest rebase #

Patch Set 8 : Latest rebase #

Patch Set 9 : Latest rebase #

Patch Set 10 : Augmenting EventPacket & InputEvent types #

Patch Set 11 : Rebase and async tracing #

Patch Set 12 : Rebase and clang format #

Patch Set 13 : Fix forward decl #

Patch Set 14 : Rebase #

Patch Set 15 : Style fixes and platform unit test build issues #

Patch Set 16 : Fix client assignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3347 lines, -637 lines) Patch
M content/browser/renderer_host/input/OWNERS View 1 2 3 4 5 9 10 11 1 chunk +1 line, -1 line 0 comments Download
A content/browser/renderer_host/input/browser_input_event.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +69 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/browser_input_event.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +47 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/buffered_input_router.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +148 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/buffered_input_router.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +344 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/buffered_input_router_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +335 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/immediate_input_router.h View 1 2 3 4 5 6 9 10 11 4 chunks +7 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/immediate_input_router.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 12 chunks +33 lines, -29 lines 0 comments Download
M content/browser/renderer_host/input/immediate_input_router_unittest.cc View 1 2 3 4 5 6 9 10 11 37 chunks +80 lines, -487 lines 0 comments Download
A content/browser/renderer_host/input/input_ack_handler.h View 1 2 3 4 5 6 9 10 11 1 chunk +36 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/input_queue.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +82 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/input_queue.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +183 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/input_queue_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +35 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/input_queue_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +378 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router.h View 1 2 3 4 5 6 9 10 11 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_client.h View 1 2 3 4 5 6 9 10 11 1 chunk +9 lines, -10 lines 0 comments Download
A content/browser/renderer_host/input/input_router_unittest.h View 1 2 3 4 5 6 9 10 11 1 chunk +83 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/input_router_unittest.cc View 1 2 3 4 5 6 9 10 11 1 chunk +225 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/mock_input_ack_handler.h View 1 2 3 4 5 6 9 10 11 1 chunk +77 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/mock_input_ack_handler.cc View 1 2 3 4 5 6 9 10 11 1 chunk +77 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/mock_input_router_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +126 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/mock_input_router_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +148 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +11 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +29 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +35 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -0 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +7 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/gpu/input_event_filter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +20 lines, -8 lines 0 comments Download
M content/renderer/gpu/input_event_filter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +74 lines, -35 lines 0 comments Download
M content/renderer/gpu/input_event_filter_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 9 chunks +292 lines, -12 lines 0 comments Download
A content/renderer/gpu/renderer_event_packet.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +71 lines, -0 lines 0 comments Download
A content/renderer/gpu/renderer_event_packet.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +136 lines, -0 lines 0 comments Download
M content/renderer/render_widget.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +18 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +78 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jdduke (slow)
nduca@, I've tried to follow the spirit of our discussion on augmenting input types in ...
7 years, 3 months ago (2013-08-30 00:46:09 UTC) #1
jdduke (slow)
On 2013/08/30 00:46:09, jdduke wrote: > nduca@, I've tried to follow the spirit of our ...
7 years, 3 months ago (2013-09-03 18:24:07 UTC) #2
nduca
7 years, 3 months ago (2013-09-03 21:48:43 UTC) #3
this lg to start breaking apart to land. i'd start with input, then input packet
and onward from there

Powered by Google App Engine
This is Rietveld 408576698