Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921893002: Faster code for megamorphic calls fo get:hashCode for Smi and OneByteString (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Faster code for megamorphic calls fo get:hashCode for Smi and OneByteString BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/733b6df785b6b2e0c34cbd182e3df8902ad9ad18

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : sync #

Total comments: 4

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -1 line) Patch
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 2 3 2 chunks +23 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 chunks +22 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
srdjan
4 years, 8 months ago (2016-04-25 22:20:16 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1921893002/diff/40001/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/1921893002/diff/40001/runtime/vm/flow_graph_compiler_arm.cc#newcode1329 runtime/vm/flow_graph_compiler_arm.cc:1329: __ b(&done, EQ); // Is Smi. // Is ...
4 years, 8 months ago (2016-04-25 22:47:10 UTC) #3
rmacnak
lgtm lgtm
4 years, 8 months ago (2016-04-25 22:47:11 UTC) #4
srdjan
https://codereview.chromium.org/1921893002/diff/40001/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/1921893002/diff/40001/runtime/vm/flow_graph_compiler_arm.cc#newcode1329 runtime/vm/flow_graph_compiler_arm.cc:1329: __ b(&done, EQ); // Is Smi. On 2016/04/25 22:47:10, ...
4 years, 8 months ago (2016-04-25 23:44:50 UTC) #5
srdjan
4 years, 8 months ago (2016-04-25 23:55:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
733b6df785b6b2e0c34cbd182e3df8902ad9ad18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698