Faster code for megamorphic calls fo get:hashCode for Smi and OneByteString

runtime/vm/flow_graph_compiler_arm.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/ast_printer.h"
@@ skipping 1301 matching lines @@
     intptr_t try_index,
     intptr_t slow_path_argument_count) {
   const String& name = String::Handle(zone(), ic_data.target_name());
   const Array& arguments_descriptor =
       Array::ZoneHandle(zone(), ic_data.arguments_descriptor());
   ASSERT(!arguments_descriptor.IsNull() && (arguments_descriptor.Length() > 0));
   const MegamorphicCache& cache = MegamorphicCache::ZoneHandle(zone(),
       MegamorphicCacheTable::Lookup(isolate(), name, arguments_descriptor));
 
   __ Comment("MegamorphicCall");
+  // Load receiver into R0.
   __ LoadFromOffset(kWord, R0, SP, (argument_count - 1) * kWordSize);
+  Label done;
+  if (name.raw() == Symbols::hashCode().raw()) {
+    Label megamorphic_call;
+    __ Comment("Inlined get:hashCode for Smi and OneByteString");
+    __ tst(R0, Operand(kSmiTagMask));
+    __ b(&done, EQ);  // Is Smi.

[rmacnak, 2016/04/25 22:47:10]

// Is Smi (result is receiver).

[srdjan, 2016/04/25 23:44:49]

Done.

+
+    // Use R9 (cache for megamorphic call) as scratch.
+    __ CompareClassId(R0, kOneByteStringCid, R9);
+    __ b(&megamorphic_call, NE);
+
+    __ mov(R9, Operand(R0));  // Preserve receiver in R9.
+    __ ldr(R0, FieldAddress(R0, String::hash_offset()));
+    __ cmp(R0, Operand(0));

[rmacnak, 2016/04/25 22:47:10]

ASSERT(Smi::New(0) == 0);

[srdjan, 2016/04/25 23:44:49]

Done.

+    __ b(&done, NE);  // Return if already computed.
+    __ mov(R0, Operand(R9));  // Restore receiver in R0.
+
+    __ Bind(&megamorphic_call);
+    __ Comment("Slow case: megamorphic call");
+  }
   __ LoadObject(R9, cache);
   if (FLAG_use_megamorphic_stub) {
     __ BranchLink(*StubCode::MegamorphicLookup_entry());
   } else {
     StubCode::EmitMegamorphicLookup(assembler());
   }
   __ blx(R1);
 
+  __ Bind(&done);
   RecordSafepoint(locs, slow_path_argument_count);
   const intptr_t deopt_id_after = Thread::ToDeoptAfter(deopt_id);
   if (FLAG_precompiled_mode) {
     // Megamorphic calls may occur in slow path stubs.
     // If valid use try_index argument.
     if (try_index == CatchClauseNode::kInvalidTryIndex) {
       try_index = CurrentTryIndex();
     }
     pc_descriptors_list()->AddDescriptor(RawPcDescriptors::kOther,
                                          assembler()->CodeSize(),
@@ skipping 635 matching lines @@
   DRegister dreg = EvenDRegisterOf(reg);
   __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
 }
 
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM