Issue 1921873004: Add a null check to ChromeActivity#onStartWithNative()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1921873004: Add a null check to ChromeActivity#onStartWithNative() (Closed)

Created:
4 years, 8 months ago by Theresa

Modified:
4 years, 8 months ago

Reviewers:
Ted C

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Add a null check to ChromeActivity#onStartWithNative() Check for getActivityTab() != null before calling getActivityTab().isLoading() BUG=606525 TBR=tedchoc@chromium.org Review URL: https://codereview.chromium.org/1921613004 Cr-Commit-Position: refs/heads/master@{#389634} Committed: https://chromium.googlesource.com/chromium/src/+/b41fc7b814761bd1e9ccd0bdf047ed9f84ae9efd

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Theresa

4 years, 8 months ago (2016-04-26 00:40:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b41fc7b814761bd1e9ccd0bdf047ed9f84ae9efd (presubmit successful).