Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1921613004: Add a null check to ChromeActivity#onStartWithNative() (Closed)

Created:
4 years, 8 months ago by Theresa
Modified:
4 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a null check to ChromeActivity#onStartWithNative() Check for getActivityTab() != null before calling getActivityTab().isLoading() BUG=606525 Committed: https://crrev.com/738ae75b8582befaf0f0cebaa45d695163f37d9f Cr-Commit-Position: refs/heads/master@{#389634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Theresa
ptal
4 years, 8 months ago (2016-04-25 23:28:22 UTC) #2
Ted C
lgtm
4 years, 8 months ago (2016-04-25 23:36:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921613004/1
4 years, 8 months ago (2016-04-25 23:39:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 00:28:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 00:29:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/738ae75b8582befaf0f0cebaa45d695163f37d9f
Cr-Commit-Position: refs/heads/master@{#389634}

Powered by Google App Engine
This is Rietveld 408576698