More FWL interface cleanup.

More FWL interface cleanup.

This CL merges the IFWL_Target class into IFWL_Widget and IFWL_Thread into
IFWL_App. The IFWL_WidgetMgrDelegate, IFWL_NoteDriver and IFWL_NotThread are
removed in favour of their concrete classes.

Committed: https://pdfium.googlesource.com/pdfium/+/7322343b9322b93d97077575f95a00dcca3f0451

[dsinclair, 2016-04-27 18:39:35]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-27 18:39:36]

PTAL.

[Tom Sepez, 2016-04-27 20:23:34]

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_appimp.cpp
File xfa/fwl/core/fwl_appimp.cpp (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_appimp.cpp...
xfa/fwl/core/fwl_appimp.cpp:22: delete m_pImpl;
Can this be unique_ptr instread?

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_appimp.cpp...
xfa/fwl/core/fwl_appimp.cpp:65: delete m_pNoteDriver;
can this too be unique_ptr ?

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_formimp.cpp
File xfa/fwl/core/fwl_formimp.cpp (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_formimp.cp...
xfa/fwl/core/fwl_formimp.cpp:418: IFWL_App* pThread = GetOwnerThread();
Can we get rid of the word Thread (maybe subsquent CL) and have
IWFL_App *pApp = GetOwnerApp();

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_noteimp.h
File xfa/fwl/core/fwl_noteimp.h (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_noteimp.h#...
xfa/fwl/core/fwl_noteimp.h:105: CFX_PtrArray m_forms;
nit: blank line here while we're at it.

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_widgetimp.cpp
File xfa/fwl/core/fwl_widgetimp.cpp (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_widgetimp....
xfa/fwl/core/fwl_widgetimp.cpp:32: delete m_pImpl;
nit: unique_ptr

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_widgetimp.h
File xfa/fwl/core/fwl_widgetimp.h (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_widgetimp....
xfa/fwl/core/fwl_widgetimp.h:151: CFWL_AppImp* m_pOwnerThread;
ditto on "thread"

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/ifwl_app.h
File xfa/fwl/core/ifwl_app.h (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/ifwl_app.h#new...
xfa/fwl/core/ifwl_app.h:10: // The FWL thread/app code contains three parallel
inheritance hierarchies,
s/parallel inheritance hierarchies/parallel classes/, unless things descend from
these, in which case give an example in the picture.

[dsinclair, 2016-04-27 20:58:55]

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_appimp.cpp
File xfa/fwl/core/fwl_appimp.cpp (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_appimp.cpp...
xfa/fwl/core/fwl_appimp.cpp:22: delete m_pImpl;
On 2016/04/27 20:23:33, Tom Sepez wrote:
> Can this be unique_ptr instread?

Done.

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_appimp.cpp...
xfa/fwl/core/fwl_appimp.cpp:65: delete m_pNoteDriver;
On 2016/04/27 20:23:33, Tom Sepez wrote:
> can this too be unique_ptr ?

Done.

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_formimp.cpp
File xfa/fwl/core/fwl_formimp.cpp (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_formimp.cp...
xfa/fwl/core/fwl_formimp.cpp:418: IFWL_App* pThread = GetOwnerThread();
On 2016/04/27 20:23:34, Tom Sepez wrote:
> Can we get rid of the word Thread (maybe subsquent CL) and have
> IWFL_App *pApp = GetOwnerApp();

Done.

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_noteimp.h
File xfa/fwl/core/fwl_noteimp.h (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_noteimp.h#...
xfa/fwl/core/fwl_noteimp.h:105: CFX_PtrArray m_forms;
On 2016/04/27 20:23:34, Tom Sepez wrote:
> nit: blank line here while we're at it.

Done.

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_widgetimp.cpp
File xfa/fwl/core/fwl_widgetimp.cpp (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_widgetimp....
xfa/fwl/core/fwl_widgetimp.cpp:32: delete m_pImpl;
On 2016/04/27 20:23:34, Tom Sepez wrote:
> nit: unique_ptr

Done.

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_widgetimp.h
File xfa/fwl/core/fwl_widgetimp.h (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_widgetimp....
xfa/fwl/core/fwl_widgetimp.h:151: CFWL_AppImp* m_pOwnerThread;
On 2016/04/27 20:23:34, Tom Sepez wrote:
> ditto on "thread"

Done.

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/ifwl_app.h
File xfa/fwl/core/ifwl_app.h (right):

https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/ifwl_app.h#new...
xfa/fwl/core/ifwl_app.h:10: // The FWL thread/app code contains three parallel
inheritance hierarchies,
On 2016/04/27 20:23:34, Tom Sepez wrote:
> s/parallel inheritance hierarchies/parallel classes/, unless things descend
from
> these, in which case give an example in the picture.

Done.

[dsinclair, 2016-04-28 14:08:39]

ping

[Tom Sepez, 2016-04-28 16:59:29]

lgtm

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_app.h
File xfa/fwl/core/ifwl_app.h (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_app.h...
xfa/fwl/core/ifwl_app.h:49: void SetImpl(CFWL_AppImp* pImpl) {
m_pImpl.reset(pImpl); }
nit: comment // Takes ownership of |pImpl|.

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_widge...
xfa/fwl/core/ifwl_widget.h:88: void SetImpl(CFWL_WidgetImp* pImpl) {
m_pImpl.reset(pImpl); }
nit: comment // Takes ownership of |pImpl|.

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_widget.cpp (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widget.cpp:217: ASSERT(m_pWidgetMgr != NULL);
nit: != NULL redundant.

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_fffiel...
File xfa/fxfa/app/xfa_fffield.cpp (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_fffiel...
xfa/fxfa/app/xfa_fffield.cpp:338: ASSERT(rtUi.width < 1.0);
nit: captain obvious?

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_ffpush...
File xfa/fxfa/app/xfa_ffpushbutton.cpp (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_ffpush...
xfa/fxfa/app/xfa_ffpushbutton.cpp:55: ASSERT(m_pNormalWidget == NULL);
nit: !m_pNormalWidget

[dsinclair, 2016-04-28 17:18:49]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-04-28 17:18:50]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1921853006/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-28 17:18:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921853006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921853006/60001

[commit-bot: I haz the power, 2016-04-28 17:51:17]

Description was changed from

==========
More FWL interface cleanup.

This CL merges the IFWL_Target class into IFWL_Widget and IFWL_Thread into
IFWL_App. The IFWL_WidgetMgrDelegate, IFWL_NoteDriver and IFWL_NotThread are
removed in favour of their concrete classes.
==========

to

==========
More FWL interface cleanup.

This CL merges the IFWL_Target class into IFWL_Widget and IFWL_Thread into
IFWL_App. The IFWL_WidgetMgrDelegate, IFWL_NoteDriver and IFWL_NotThread are
removed in favour of their concrete classes.

Committed:
https://pdfium.googlesource.com/pdfium/+/7322343b9322b93d97077575f95a00dcca3f...
==========

[commit-bot: I haz the power, 2016-04-28 17:51:18]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/7322343b9322b93d97077575f95a00dcca3f...

[dsinclair, 2016-04-28 18:00:59]

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_app.h
File xfa/fwl/core/ifwl_app.h (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_app.h...
xfa/fwl/core/ifwl_app.h:49: void SetImpl(CFWL_AppImp* pImpl) {
m_pImpl.reset(pImpl); }
On 2016/04/28 16:59:29, Tom Sepez wrote:
> nit: comment // Takes ownership of |pImpl|.

Done.

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_widge...
xfa/fwl/core/ifwl_widget.h:88: void SetImpl(CFWL_WidgetImp* pImpl) {
m_pImpl.reset(pImpl); }
On 2016/04/28 16:59:29, Tom Sepez wrote:
> nit: comment // Takes ownership of |pImpl|.

Done.

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_widget.cpp (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widget.cpp:217: ASSERT(m_pWidgetMgr != NULL);
On 2016/04/28 16:59:29, Tom Sepez wrote:
> nit: != NULL redundant.

Done.

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_fffiel...
File xfa/fxfa/app/xfa_fffield.cpp (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_fffiel...
xfa/fxfa/app/xfa_fffield.cpp:338: ASSERT(rtUi.width < 1.0);
On 2016/04/28 16:59:29, Tom Sepez wrote:
> nit: captain obvious?

Done.

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_ffpush...
File xfa/fxfa/app/xfa_ffpushbutton.cpp (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_ffpush...
xfa/fxfa/app/xfa_ffpushbutton.cpp:55: ASSERT(m_pNormalWidget == NULL);
On 2016/04/28 16:59:29, Tom Sepez wrote:
> nit: !m_pNormalWidget

Done.