Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1921853006: More FWL interface cleanup. (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

More FWL interface cleanup. This CL merges the IFWL_Target class into IFWL_Widget and IFWL_Thread into IFWL_App. The IFWL_WidgetMgrDelegate, IFWL_NoteDriver and IFWL_NotThread are removed in favour of their concrete classes. Committed: https://pdfium.googlesource.com/pdfium/+/7322343b9322b93d97077575f95a00dcca3f0451

Patch Set 1 #

Total comments: 14

Patch Set 2 : #

Patch Set 3 : Rebase to master #

Total comments: 10

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -556 lines) Patch
M BUILD.gn View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M xfa.gyp View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_caretimp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_checkboximp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_comboboximp.cpp View 1 4 chunks +11 lines, -11 lines 0 comments Download
M xfa/fwl/basewidget/fwl_datetimepickerimp.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_formproxyimp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_monthcalendarimp.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_pictureboximp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_pushbuttonimp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_spinbuttonimp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/core/cfwl_themepart.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M xfa/fwl/core/fwl_appimp.h View 1 2 chunks +13 lines, -4 lines 0 comments Download
M xfa/fwl/core/fwl_appimp.cpp View 1 2 chunks +17 lines, -5 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 1 6 chunks +26 lines, -20 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.h View 1 2 4 chunks +31 lines, -23 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 1 2 4 chunks +12 lines, -11 lines 0 comments Download
M xfa/fwl/core/fwl_sdadapterimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_sdadapterimp.cpp View 2 chunks +1 line, -3 lines 0 comments Download
D xfa/fwl/core/fwl_targetimp.h View 1 chunk +0 lines, -27 lines 0 comments Download
D xfa/fwl/core/fwl_targetimp.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D xfa/fwl/core/fwl_threadimp.h View 1 chunk +0 lines, -33 lines 0 comments Download
D xfa/fwl/core/fwl_threadimp.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M xfa/fwl/core/fwl_timerimp.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.h View 1 3 chunks +14 lines, -10 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.cpp View 1 13 chunks +74 lines, -29 lines 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.h View 2 chunks +15 lines, -10 lines 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.cpp View 1 2 chunks +10 lines, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_adapternative.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_adapterthreadmgr.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_app.h View 1 2 3 2 chunks +30 lines, -4 lines 0 comments Download
D xfa/fwl/core/ifwl_notedriver.h View 1 chunk +0 lines, -49 lines 0 comments Download
D xfa/fwl/core/ifwl_noteloop.h View 1 chunk +0 lines, -21 lines 0 comments Download
D xfa/fwl/core/ifwl_target.h View 1 chunk +0 lines, -52 lines 0 comments Download
D xfa/fwl/core/ifwl_thread.h View 1 chunk +0 lines, -43 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 1 2 3 2 chunks +38 lines, -4 lines 0 comments Download
D xfa/fwl/core/ifwl_widgetmgrdelegate.h View 1 chunk +0 lines, -33 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_tooltip.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_widget.cpp View 1 2 3 6 chunks +23 lines, -15 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpushbutton.cpp View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.h View 2 chunks +1 line, -2 lines 0 comments Download
M xfa/fxfa/include/xfa_ffapp.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-04-27 18:39:36 UTC) #2
Tom Sepez
https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_appimp.cpp File xfa/fwl/core/fwl_appimp.cpp (right): https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_appimp.cpp#newcode22 xfa/fwl/core/fwl_appimp.cpp:22: delete m_pImpl; Can this be unique_ptr instread? https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_appimp.cpp#newcode65 xfa/fwl/core/fwl_appimp.cpp:65: ...
4 years, 7 months ago (2016-04-27 20:23:34 UTC) #3
dsinclair
https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_appimp.cpp File xfa/fwl/core/fwl_appimp.cpp (right): https://codereview.chromium.org/1921853006/diff/1/xfa/fwl/core/fwl_appimp.cpp#newcode22 xfa/fwl/core/fwl_appimp.cpp:22: delete m_pImpl; On 2016/04/27 20:23:33, Tom Sepez wrote: > ...
4 years, 7 months ago (2016-04-27 20:58:55 UTC) #4
dsinclair
ping
4 years, 7 months ago (2016-04-28 14:08:39 UTC) #5
Tom Sepez
lgtm https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_app.h File xfa/fwl/core/ifwl_app.h (right): https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_app.h#newcode49 xfa/fwl/core/ifwl_app.h:49: void SetImpl(CFWL_AppImp* pImpl) { m_pImpl.reset(pImpl); } nit: comment ...
4 years, 7 months ago (2016-04-28 16:59:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921853006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921853006/60001
4 years, 7 months ago (2016-04-28 17:18:58 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://pdfium.googlesource.com/pdfium/+/7322343b9322b93d97077575f95a00dcca3f0451
4 years, 7 months ago (2016-04-28 17:51:18 UTC) #11
dsinclair
4 years, 7 months ago (2016-04-28 18:00:59 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_app.h
File xfa/fwl/core/ifwl_app.h (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_app.h...
xfa/fwl/core/ifwl_app.h:49: void SetImpl(CFWL_AppImp* pImpl) {
m_pImpl.reset(pImpl); }
On 2016/04/28 16:59:29, Tom Sepez wrote:
> nit: comment // Takes ownership of |pImpl|.

Done.

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/core/ifwl_widge...
xfa/fwl/core/ifwl_widget.h:88: void SetImpl(CFWL_WidgetImp* pImpl) {
m_pImpl.reset(pImpl); }
On 2016/04/28 16:59:29, Tom Sepez wrote:
> nit: comment // Takes ownership of |pImpl|.

Done.

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_widget.cpp (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widget.cpp:217: ASSERT(m_pWidgetMgr != NULL);
On 2016/04/28 16:59:29, Tom Sepez wrote:
> nit: != NULL redundant.

Done.

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_fffiel...
File xfa/fxfa/app/xfa_fffield.cpp (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_fffiel...
xfa/fxfa/app/xfa_fffield.cpp:338: ASSERT(rtUi.width < 1.0);
On 2016/04/28 16:59:29, Tom Sepez wrote:
> nit: captain obvious?

Done.

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_ffpush...
File xfa/fxfa/app/xfa_ffpushbutton.cpp (right):

https://codereview.chromium.org/1921853006/diff/40001/xfa/fxfa/app/xfa_ffpush...
xfa/fxfa/app/xfa_ffpushbutton.cpp:55: ASSERT(m_pNormalWidget == NULL);
On 2016/04/28 16:59:29, Tom Sepez wrote:
> nit: !m_pNormalWidget

Done.

Powered by Google App Engine
This is Rietveld 408576698