More FWL interface cleanup.

xfa/fwl/core/ifwl_app.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FWL_CORE_IFWL_APP_H_
 #define XFA_FWL_CORE_IFWL_APP_H_
 
+// The FWL thread/app code contains three parallel inheritance hierarchies,

[Tom Sepez, 2016/04/27 20:23:34]

s/parallel inheritance hierarchies/parallel classes/, unless things descend from
these, in which case give an example in the picture.

[dsinclair, 2016/04/27 20:58:55]

Done.

+// which reference each other via pointers as follows:
+//
+//                    m_pIface               m_pImpl
+//      CXFA_FFApp ------------> IFWL_App -----------> CFWL_AppImp
+//                                        <-----------
+//                                           m_pIface
+
 #include "core/fxcrt/include/fx_string.h"
-#include "xfa/fwl/core/ifwl_thread.h"
+#include "xfa/fwl/core/fwl_error.h"
 
+class CFWL_AppImp;
+class CFWL_NoteDriver;
 class IFWL_AdapterNative;
+class IFWL_AdapterWidgetMgr;
+class IFWL_ThemeProvider;
 class IFWL_Widget;
 class IFWL_WidgetMgr;
-class IFWL_ThemeProvider;
-class IFWL_AdapterWidgetMgr;
 
-class IFWL_App : public IFWL_Thread {
+class IFWL_App {
  public:
   static IFWL_App* Create(IFWL_AdapterNative* pAdapter);
 
+  virtual ~IFWL_App() {}
+
   FWL_ERR Initialize();
   FWL_ERR Finalize();
   IFWL_AdapterNative* GetAdapterNative();
   IFWL_WidgetMgr* GetWidgetMgr();
   IFWL_ThemeProvider* GetThemeProvider();
   FWL_ERR SetThemeProvider(IFWL_ThemeProvider* pThemeProvider);
   FWL_ERR Exit(int32_t iExitCode);
 
+  // These call into polymorphic methods in the impl; no need to override.
+  void Release();
+
+  CFWL_AppImp* GetImpl() const { return m_pImpl; }
+  void SetImpl(CFWL_AppImp* pImpl) { m_pImpl = pImpl; }
+
+  CFWL_NoteDriver* GetNoteDriver() const;
+
  private:
   IFWL_App() {}
+
+  CFWL_AppImp* m_pImpl;
 };
 
 IFWL_App* FWL_GetApp();
 void FWL_SetApp(IFWL_App* pApp);
 
 IFWL_AdapterNative* FWL_GetAdapterNative();
 IFWL_AdapterWidgetMgr* FWL_GetAdapterWidgetMgr();
 
 #endif  // XFA_FWL_CORE_IFWL_APP_H_