Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921823006: Fix parsing of <body link vlink alink> (Closed)

Created:
4 years, 7 months ago by Anton Obzhirov
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix parsing of <body link vlink alink> We use the correct legacy rules for bgcolor and text but not the link/vlink/alink attributes on body. This should also not be conditional on quirks mode. The change adds parsing color from link/vlink/alink attributes using legacy rules. BUG=605534 Committed: https://crrev.com/ac6c480c0c078999a785de7ef1e10c6c0c928c75 Cr-Commit-Position: refs/heads/master@{#395242}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -18 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/HTMLBodyElement/body-legacy-colors.html View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/HTMLBodyElement/body-legacy-colors-expected.txt View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLBodyElement.cpp View 1 1 chunk +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 2 1 chunk +19 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
simonp
https://codereview.chromium.org/1921823006/diff/1/third_party/WebKit/Source/core/html/HTMLBodyElement.cpp File third_party/WebKit/Source/core/html/HTMLBodyElement.cpp (right): https://codereview.chromium.org/1921823006/diff/1/third_party/WebKit/Source/core/html/HTMLBodyElement.cpp#newcode98 third_party/WebKit/Source/core/html/HTMLBodyElement.cpp:98: if (!CSSParser::parseColor(color, value, !document().inQuirksMode()) Maybe I'm missing something but ...
4 years, 7 months ago (2016-04-29 13:37:19 UTC) #5
Anton Obzhirov
Thanks for review, I will update the patch. https://codereview.chromium.org/1921823006/diff/1/third_party/WebKit/Source/core/html/HTMLBodyElement.cpp File third_party/WebKit/Source/core/html/HTMLBodyElement.cpp (right): https://codereview.chromium.org/1921823006/diff/1/third_party/WebKit/Source/core/html/HTMLBodyElement.cpp#newcode98 third_party/WebKit/Source/core/html/HTMLBodyElement.cpp:98: if ...
4 years, 7 months ago (2016-05-04 13:23:48 UTC) #6
dominicc (has gone to gerrit)
Please add a test! https://codereview.chromium.org/1921823006/diff/20001/third_party/WebKit/Source/core/html/HTMLElement.h File third_party/WebKit/Source/core/html/HTMLElement.h (right): https://codereview.chromium.org/1921823006/diff/20001/third_party/WebKit/Source/core/html/HTMLElement.h#newcode110 third_party/WebKit/Source/core/html/HTMLElement.h:110: static bool parseColorWithLegacyRules(const String& attributeValue, ...
4 years, 7 months ago (2016-05-10 08:18:33 UTC) #7
Anton Obzhirov
On 2016/05/10 08:18:33, dominicc wrote: > Please add a test! > > https://codereview.chromium.org/1921823006/diff/20001/third_party/WebKit/Source/core/html/HTMLElement.h > File ...
4 years, 7 months ago (2016-05-10 12:12:09 UTC) #8
Anton Obzhirov
Hi guys, I submitted a new patch few days ago with a test, plz have ...
4 years, 7 months ago (2016-05-18 09:54:24 UTC) #9
dominicc (has gone to gerrit)
lgtm
4 years, 7 months ago (2016-05-21 00:31:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921823006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921823006/40001
4 years, 7 months ago (2016-05-21 00:31:59 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-21 03:21:32 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 03:23:10 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ac6c480c0c078999a785de7ef1e10c6c0c928c75
Cr-Commit-Position: refs/heads/master@{#395242}

Powered by Google App Engine
This is Rietveld 408576698