third_party/WebKit/Source/core/html/HTMLBodyElement.cpp - Issue 1921823006: Fix parsing of <body link vlink alink>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLBodyElement.cpp

Issue 1921823006: Fix parsing of <body link vlink alink> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLBodyElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLBodyElement.cpp b/third_party/WebKit/Source/core/html/HTMLBodyElement.cpp

index 3de09f468785710fffa0189a9774fcfa011f1e18..b02addcd392c180b000cb4dd7a636527be5361f0 100644

--- a/third_party/WebKit/Source/core/html/HTMLBodyElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLBodyElement.cpp

@@ -94,14 +94,16 @@ void HTMLBodyElement::parseAttribute(const QualifiedName& name, const AtomicStri

document().textLinkColors().resetActiveLinkColor();

} else {

Color color;

- if (CSSParser::parseColor(color, value, !document().inQuirksMode())) {

- if (name == linkAttr)

- document().textLinkColors().setLinkColor(color);

- else if (name == vlinkAttr)

- document().textLinkColors().setVisitedLinkColor(color);

- else

- document().textLinkColors().setActiveLinkColor(color);

- }

+ String stringValue = value;

+ if (!HTMLElement::parseColorWithLegacyRules(stringValue, color))

+ return;

+ if (name == linkAttr)

+ document().textLinkColors().setLinkColor(color);

+ else if (name == vlinkAttr)

+ document().textLinkColors().setVisitedLinkColor(color);

+ else

+ document().textLinkColors().setActiveLinkColor(color);

}

setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::LinkColorChange));