Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1921743003: Fix an issue that HLS url for Azure video is not correctly detected (Closed)

Created:
4 years, 8 months ago by qinmin
Modified:
4 years, 8 months ago
Reviewers:
no sievers
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix an issue that HLS url for Azure video is not correctly detected Azure video may have the following url: http://b028.wpc.azureedge.net/80B028/Samples/a38e6323-95e9-4f1f-9b38-75eba91704e4/5f2ce531-d508-49fb-8152-647eba422aec.ism/Manifest(format=m3u8-aapl-v3) Use IsHLSURL() instead of IsHLSPath() fixes the issue. IsHLSURL() could introduce higher false positives. However, in false positive case the url will be passed to Android MediaPlayer, which will also play the video for us. TBR=sievers@chromium.org BUG=605691 Review URL: https://codereview.chromium.org/1905133003 Cr-Commit-Position: refs/heads/master@{#388930} (cherry picked from commit bc609e6aaf5e4f7bf7aef788d05e070ad440e9e7) Committed: https://chromium.googlesource.com/chromium/src/+/d9f99ce9da604abdb416de7828adb64b9ac15b99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
4 years, 8 months ago (2016-04-25 16:25:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d9f99ce9da604abdb416de7828adb64b9ac15b99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698