Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1905133003: Fix an issue that HLS url for Azure video is not correctly detected (Closed)

Created:
4 years, 8 months ago by qinmin
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that HLS url for Azure video is not correctly detected Azure video may have the following url: http://b028.wpc.azureedge.net/80B028/Samples/a38e6323-95e9-4f1f-9b38-75eba91704e4/5f2ce531-d508-49fb-8152-647eba422aec.ism/Manifest(format=m3u8-aapl-v3) Use IsHLSURL() instead of IsHLSPath() fixes the issue. IsHLSURL() could introduce higher false positives. However, in false positive case the url will be passed to Android MediaPlayer, which will also play the video for us. BUG=605691 Committed: https://crrev.com/bc609e6aaf5e4f7bf7aef788d05e070ad440e9e7 Cr-Commit-Position: refs/heads/master@{#388930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 8 months ago (2016-04-21 19:54:04 UTC) #2
no sievers
lgtm
4 years, 8 months ago (2016-04-21 20:17:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905133003/1
4 years, 8 months ago (2016-04-21 20:57:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 22:36:06 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:40:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc609e6aaf5e4f7bf7aef788d05e070ad440e9e7
Cr-Commit-Position: refs/heads/master@{#388930}

Powered by Google App Engine
This is Rietveld 408576698