[Telemetry] Rename page_test to legacy_page_test

[Telemetry] Rename page_test to legacy_page_test

This is to make it clearer for telemetry users that TBMV2 is the way to write a
new performance benchmarks.

After all the sites in chromium/src is updated to reference
legacy_page_test.LegacyPageTest (crbug.com/606643), I will remove 
the shim.

BUG=catapult:#2218

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/254b0aa0b9c710ff983d3256433543f58ac2db15

[nednguyen, 2016-04-26 03:39:43]

nednguyen@google.com changed reviewers:
+ aiolos@chromium.org, eakuefner@chromium.org, sullivan@chromium.org

[nednguyen, 2016-04-26 03:39:44]

FWIW, I takes this clean up as urgent because the service worker team in Tokyo
recently make a huge amount of work based on this legacy structure & only knows
about that this is "legacy" at review time.

According to Kouhei@'s experience, naming legacy stuffs with "legacy-" prefix is
an effective way to deal with this, as he was able to know tbmv1 is legacy right
away due to the SetLegacyTimelineBasedMetric naming.

[nednguyen, 2016-04-26 03:49:44]

Description was changed from

==========
[Telemetry] Rename page_test to legacy_page_test

This is to make it clearer for telemetry users that TBMV2 is the way to write a
new performance benchmarks.

After all the sites in chromium/src is updated to reference
legacy_page_test.LegacyPageTest, I will remove the shim.

BUG=catapult:#2218
==========

to

==========
[Telemetry] Rename page_test to legacy_page_test

This is to make it clearer for telemetry users that TBMV2 is the way to write a
new performance benchmarks.

After all the sites in chromium/src is updated to reference
legacy_page_test.LegacyPageTest (crbug.com/606643), I will remove 
the shim.

BUG=catapult:#2218
==========

[eakuefner, 2016-04-26 05:07:28]

lgtm, and thanks for taking this on -- just be wary of chromium-side
modifications that may or may not need to be done.

[nednguyen, 2016-04-26 05:26:00]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-04-26 05:26:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921633003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921633003/20001

[nednguyen, 2016-04-26 05:26:20]

On 2016/04/26 05:07:28, eakuefner (OOO until Apr 25) wrote:
> lgtm, and thanks for taking this on -- just be wary of chromium-side
> modifications that may or may not need to be done.

What do you mean that "may not need to be done?"

[commit-bot: I haz the power, 2016-04-26 05:46:42]

Description was changed from

==========
[Telemetry] Rename page_test to legacy_page_test

This is to make it clearer for telemetry users that TBMV2 is the way to write a
new performance benchmarks.

After all the sites in chromium/src is updated to reference
legacy_page_test.LegacyPageTest (crbug.com/606643), I will remove 
the shim.

BUG=catapult:#2218
==========

to

==========
[Telemetry] Rename page_test to legacy_page_test

This is to make it clearer for telemetry users that TBMV2 is the way to write a
new performance benchmarks.

After all the sites in chromium/src is updated to reference
legacy_page_test.LegacyPageTest (crbug.com/606643), I will remove 
the shim.

BUG=catapult:#2218

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-04-26 05:46:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[eakuefner, 2016-04-26 05:49:20]

On 2016/04/26 at 05:26:20, nednguyen wrote:
> On 2016/04/26 05:07:28, eakuefner (OOO until Apr 25) wrote:
> > lgtm, and thanks for taking this on -- just be wary of chromium-side
> > modifications that may or may not need to be done.
> 
> What do you mean that "may not need to be done?"

Sorry, just meant that if there are any references to page_test in Chromium that
would need to be taken account, but was too lazy to look into it myself.